From: Antony Pavlov <antonynpavlov@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v9 04/12] MIPS: add common MIPS stuff
Date: Wed, 3 Aug 2011 17:53:46 +0400 [thread overview]
Message-ID: <CAA4bVAGVD7YaOfMhhiE-eKJoXz3Vh+ar6oNCGBOb2wrm1U7V1A@mail.gmail.com> (raw)
In-Reply-To: <20110803125446.GC24730@game.jcrosoft.org>
On 3 August 2011 16:54, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
>> index e37b6c5..2b3227a 100644
>> --- a/arch/mips/include/asm/common.h
>> +++ b/arch/mips/include/asm/common.h
>> @@ -24,6 +24,17 @@
>> #ifndef _ASM_MIPS_COMMON_H_
>> #define _ASM_MIPS_COMMON_H_
>>
>> -/* nothing special yet */
>> +#define NS16550_READ_WRITE_UART_FUNC(pfx, shift, offset) \
>> +static unsigned int pfx ##_uart_read(unsigned long base, \
>> + unsigned char reg_idx) \
>> +{ \
>> + return __raw_readb((char *)base + (reg_idx << shift) + offset); \
>> +} \
>> + \
>> +static void pfx ##_uart_write(unsigned int val, unsigned long base, \
>> + unsigned char reg_idx) \
>> +{ \
>> + __raw_writeb(val, (char *)base + (reg_idx << shift) + offset); \
>> +} \
> you can drop this
>
> add the following patch instead as will need readb/w/l and writeb/w/l for
> cfi support anyway
Unfortunately, I can't drop it just now. But I will try to drop it in
nearest future. Apropos, cfi does not work for me just now either.
> otherwise lokks very good
Thanks!
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-08-03 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 9:10 [PATCH v9 01/12] MIPS: initial commit: add empty but required header files Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 02/12] MIPS: import libgcc-related files from linux-2.6.39 Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 03/12] MIPS: import header files Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 04/12] MIPS: add common MIPS stuff Antony Pavlov
2011-08-03 12:54 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-03 13:53 ` Antony Pavlov [this message]
2011-08-03 9:10 ` [PATCH v9 05/12] MIPS: add documentation Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 06/12] MIPS: add Malta machine support to barebox Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 07/12] MIPS: add qemu malta board " Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 08/12] MIPS: add qemu-malta documentation Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 09/12] MIPS: add initial BCM47xx-based boards support Antony Pavlov
2011-08-03 9:10 ` [PATCH v9 10/12] MIPS: add initial D-Link DIR-320 wireless router support Antony Pavlov
2011-08-03 9:11 ` [PATCH v9 11/12] MIPS: add D-Link DIR-320 documentation Antony Pavlov
2011-08-03 9:11 ` [PATCH v9 12/12] MIPS: add draft cpuinfo command Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4bVAGVD7YaOfMhhiE-eKJoXz3Vh+ar6oNCGBOb2wrm1U7V1A@mail.gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox