From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ehci-hcd.c: handle EHCI_HAS_TT in ehci_reset() during startup
Date: Tue, 13 Sep 2011 21:04:47 +0400 [thread overview]
Message-ID: <CAA4bVAGiQ9AyRc3-GPaet6uwGcETpFcbi=OMAYi0uNdc_JonZA@mail.gmail.com> (raw)
In-Reply-To: <CAA4bVAGbz4aDRgRbKDj6OqDhSdXBb9KK5nRNjfDfyW5NM=Dh4w@mail.gmail.com>
On 13 September 2011 16:14, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> On 13 September 2011 11:34, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>> On Mon, Sep 12, 2011 at 02:26:00PM +0400, Antony Pavlov wrote:
>>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>>> ---
>>> drivers/usb/host/ehci-hcd.c | 9 ++-------
>>> 1 files changed, 2 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
>>> index 60fc181..883dc07 100644
>>> --- a/drivers/usb/host/ehci-hcd.c
>>> +++ b/drivers/usb/host/ehci-hcd.c
>>> @@ -921,15 +921,10 @@ static int ehci_probe(struct device_d *dev)
>>> host->submit_control_msg = submit_control_msg;
>>> host->submit_bulk_msg = submit_bulk_msg;
>>>
>>> - if (ehci->flags & EHCI_HAS_TT) {
>>> - /* Set to host mode */
>>> - reg = ehci_readl(ehci->hcor + USBMODE);
>>> - reg |= USBMODE_CM_HC;
>>> - writel(reg, ehci->hcor + USBMODE);
>>> - }
>>> -
>>> usb_register_host(host);
>>>
>>> + ehci_reset(ehci);
>>> +
>>
>> ehci_reset is called from ehci_init. Isn't that enough or do we have to
>> call it explicitely here?
>
> I suppose it's preferable reset the controller after changing "host
> controller mode" bit (USBMODE_CM_HC). Let's check the file
> drivers/usb/host/ehci-hcd.c from linux kernel sources, in ehci_reset()
> we have:
>
> if (ehci_is_TDI(ehci))
> tdi_reset (ehci);
>
May be this "patch" (linux-style) will be better?
host->submit_control_msg = submit_control_msg;
host->submit_bulk_msg = submit_bulk_msg;
if (ehci->flags & EHCI_HAS_TT) {
- /* Set to host mode */
- reg = ehci_readl(ehci->hcor + USBMODE);
- reg |= USBMODE_CM_HC;
- writel(reg, ehci->hcor + USBMODE);
+ ehci_reset(ehci);
}
usb_register_host(host);
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-09-13 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 10:26 Antony Pavlov
2011-09-13 7:34 ` Sascha Hauer
2011-09-13 12:14 ` Antony Pavlov
2011-09-13 17:04 ` Antony Pavlov [this message]
2011-09-16 6:04 Antony Pavlov
2011-09-19 9:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAGiQ9AyRc3-GPaet6uwGcETpFcbi=OMAYi0uNdc_JonZA@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox