mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: AbdelRahman Yossef <abdelrahmanyossef12@gmail.com>
To: barebox@lists.infradead.org, Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v4] of: fdt: fix possible overflow during parsing of fdt
Date: Thu, 14 Nov 2024 19:50:49 +0200	[thread overview]
Message-ID: <CABwgSGZ88oyWPQwv=5E_OkMV4Pn1Usk8M3MVAUTnFojzS8NLxw@mail.gmail.com> (raw)
In-Reply-To: <CABwgSGYcFoMncRWoyOjG19K2GiuMjrEomNGvG3E2fEX3wiM=RA@mail.gmail.com>

Hi Jules,

I think everything you said is correct, except just the last line
because strnlen
returns the minimum of the length of the string and maxlength + 1 (It
will not access forbidden location).

So in my opinion it's not a bug or suspicious but only unnecessary.

Cheers,
Abdelrahman



  parent reply	other threads:[~2024-11-14 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 15:51 Abdelrahman Youssef
2024-11-14 16:39 ` Jules Maselbas
     [not found]   ` <CABwgSGY3SQGUoc3xY9XVX3aHwRV6s5xFuKABtgCf0vT26-1=_Q@mail.gmail.com>
     [not found]     ` <CABwgSGYcFoMncRWoyOjG19K2GiuMjrEomNGvG3E2fEX3wiM=RA@mail.gmail.com>
2024-11-14 17:50       ` AbdelRahman Yossef [this message]
2024-11-15 20:15 ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABwgSGZ88oyWPQwv=5E_OkMV4Pn1Usk8M3MVAUTnFojzS8NLxw@mail.gmail.com' \
    --to=abdelrahmanyossef12@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox