* Little bug @ 2014-09-30 20:03 luigi origa 2014-10-01 6:02 ` Sascha Hauer 0 siblings, 1 reply; 3+ messages in thread From: luigi origa @ 2014-09-30 20:03 UTC (permalink / raw) To: barebox I found a little bug in your code. The structure "fb_videomode" contains a field "display_flags" but selecting "video svga" or "video a70" the code initialize the struct using the field ".flag". Obviously the compiler in this case, exit with an error. Luigi _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Little bug 2014-09-30 20:03 Little bug luigi origa @ 2014-10-01 6:02 ` Sascha Hauer [not found] ` <CACSabZ8wCRJAE2Oc2ZrQGQg5=X=mRJ9OF14tiC981=zWRSaTiw@mail.gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Sascha Hauer @ 2014-10-01 6:02 UTC (permalink / raw) To: luigi origa; +Cc: barebox Hi Luigi, On Tue, Sep 30, 2014 at 10:03:39PM +0200, luigi origa wrote: > I found a little bug in your code. > > The structure "fb_videomode" contains a field "display_flags" but > selecting "video svga" or "video a70" the code initialize the struct > using the field ".flag". Obviously the compiler in this case, exit > with an error. Could you tell us which files exactly have this bug? barebox neither has a a70 nor a svga driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CACSabZ8wCRJAE2Oc2ZrQGQg5=X=mRJ9OF14tiC981=zWRSaTiw@mail.gmail.com>]
* Re: Little bug [not found] ` <CACSabZ8wCRJAE2Oc2ZrQGQg5=X=mRJ9OF14tiC981=zWRSaTiw@mail.gmail.com> @ 2014-10-01 12:03 ` luigi origa 0 siblings, 0 replies; 3+ messages in thread From: luigi origa @ 2014-10-01 12:03 UTC (permalink / raw) To: barebox Few days ago i got the files using git but in this moment i'm out so i downloaded the file "barebox-2014.08.0.tar.bz2". Looking inside i found the same error. Open the file "barebox-2014.08.0\arch\arm\boards\friendlyarm-mini2440\mini2440.c" and goto at line 84. #ifdef CONFIG_MINI2440_VIDEO_A70 { .name = "A70", .refresh = 50, .xres = 800, .left_margin = 40, .right_margin = 40, .hsync_len = 48, .yres = 480, .upper_margin = 29, .lower_margin = 3, .vsync_len = 3, .pixclock = 41848, .sync = FB_SYNC_USE_PWREN | FB_SYNC_DE_HIGH_ACT, .vmode = FB_VMODE_NONINTERLACED, .flag = 0, // <<<<<<<<<<<<<<<<<<<<<<<< mismatch }, #endif #ifdef CONFIG_MINI2440_VIDEO_SVGA { .name = "SVGA", .refresh = 24, .xres = 1024, .left_margin = 1, .right_margin = 2, .hsync_len = 2, .yres = 768, .upper_margin = 200, .lower_margin = 16, .vsync_len = 16, .pixclock = 40492, .sync = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT | FB_SYNC_DE_HIGH_ACT /* | FB_SYNC_SWAP_HW */ /* FIXME maybe */ , .vmode = FB_VMODE_NONINTERLACED, .flag = 0, // <<<<<<<<<<<<<<<<<<<<<<<< mismatch }, #endif Luigi _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-01 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-30 20:03 Little bug luigi origa
2014-10-01 6:02 ` Sascha Hauer
[not found] ` <CACSabZ8wCRJAE2Oc2ZrQGQg5=X=mRJ9OF14tiC981=zWRSaTiw@mail.gmail.com>
2014-10-01 12:03 ` luigi origa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox