Re: [PATCH V2 2/2] at91sam9g45: clock: add i2c clocks

["Raphaël Poggi" <raphio98@gmail.com>]

Hi,

I have used CLKDEV_CON_DEV_ID because it is like that in Linux, but ok
I will replace it by CLKDEV_DEV_ID.

Btw, can you explain me why in Linux it's CLKDEV_CON_DEV_ID ? (just by
curiosity)

Thanks,

Raphaël Poggi

2014-08-04 11:17 GMT+02:00 Bo Shen <voice.shen@atmel.com>:
> Hi Raphaël Poggi,
>
>
> On 08/04/2014 04:31 PM, Raphaël Poggi wrote:
>>
>> Add the device tree and non device tree at91 i2c clocks.
>>
>> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
>> ---
>>   arch/arm/mach-at91/at91sam9g45.c |    4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mach-at91/at91sam9g45.c
>> b/arch/arm/mach-at91/at91sam9g45.c
>> index f6031f0..d0f950c 100644
>> --- a/arch/arm/mach-at91/at91sam9g45.c
>> +++ b/arch/arm/mach-at91/at91sam9g45.c
>> @@ -192,6 +192,10 @@ static struct clk_lookup periph_clocks_lookups[] = {
>>         CLKDEV_CON_DEV_ID("mci_clk", "atmel_mci1", &mmc1_clk),
>>         CLKDEV_CON_DEV_ID("spi_clk", "atmel_spi0", &spi0_clk),
>>         CLKDEV_CON_DEV_ID("spi_clk", "atmel_spi1", &spi1_clk),
>> +       CLKDEV_CON_DEV_ID(NULL, "at91-twi0", &twi0_clk),
>
>
> s/CLKDEV_CON_DEV_ID/CLKDEV_DEV_ID (also for the following).
>
> the DEV_ID should be presented in the id_table in the driver.
>
>
>> +       CLKDEV_CON_DEV_ID(NULL, "at91-twi1", &twi1_clk),
>> +       CLKDEV_CON_DEV_ID(NULL, "fff84000.i2c", &twi0_clk),
>> +       CLKDEV_CON_DEV_ID(NULL, "fff88000.i2c", &twi1_clk),
>>         CLKDEV_DEV_ID("at91rm9200-gpio0", &pioA_clk),
>>         CLKDEV_DEV_ID("at91rm9200-gpio1", &pioB_clk),
>>         CLKDEV_DEV_ID("at91rm9200-gpio2", &pioC_clk),
>>
>
> Best Regards,
> Bo Shen
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox