Re: am335x: load a kernel with integrated initramfs

[Yegor Yefremov <yegorslists@googlemail.com>]

Hi Sascha,

On Mon, Mar 23, 2020 at 9:30 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> Hi Yegor,
>
> On Fri, Mar 20, 2020 at 09:29:04AM +0100, Yegor Yefremov wrote:
> > I get an "handler failed with: Out of memory" message when trying to
> > load my 22MB large kernel-fit.itb. Below you can see the related log:
> >
> > mounted /dev/nand0.UBI.ubi.kernel on /mnt/nand0.UBI.ubi.kernel
> > YY: bootm_boot
> > YY: read file 0, size 22661672, PAGE_SIZE 4096
> > YY: fit_open
> > FIT: Opened FIT image: Simple image with single Linux kernel and FDT blob
> > FIT: configuration 'conf221@1': Boot Linux kernel with FDT blob (221)
> > FIT: image 'kernel@1': 'Vanilla Linux kernel'
> > FIT: /images/kernel@1/hash@1: hash OK
> >
> > Loading open firmware Device Tree flattened Binary
> > '/mnt/nand0.UBI.ubi.kernel/kernel-fit.itb'
> > OS image not yet relocated
> > Passing control to FIT image handler
> > YY: do_bootm_linux
> > YY: before bootm_load_os
> > YY: bootm_load_os
> > YY: kernel size 22484352
> > YY: for each memory bank: size 22484352
> > __request_region: 0x86b37000:0x880a857f conflicts with 0x87efe860:0x8fdfd0bf
>
> So your kernel has a size of 22484352 bytes. We want to places the
> kernel at a place where we do not risk that it overwrites itself during
> decompression. We assume that the kernel gets five times bigger during
> decompression. So we put it at 0x80000000 + 22484352 * 5. Here the image
> takes 22484352 bytes, so ends at 0x80000000 + 22484352 * (5 + 1) which
> is already inside the malloc area.
>
> Try the attached patch, it should solve that issue.

No, it doesn't. But reducing the malloc size helped. I have tried the
reduced size with and without the fix.

Yegor

> Besides this obvious bug you can also adjust the sime of the malloc
> area. By default roughly half of the available RAM is used for malloc,
> but in Kconfig you can adjust it to a smaller size which gives you more
> place for the kernel.
>
> Sascha
>
> --------------------------------------8<-------------------------------
>
> From ca440da09c3cdb83e17a6f0a99f24f69300c0ba3 Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Mon, 23 Mar 2020 09:17:36 +0100
> Subject: [PATCH] ARM: bootm: make sure we place the kernel in free memory
>
> When placing the kernel image in memory make sure we do not
> place it too high, outside of the available memory, outside of the
> available memory.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/lib32/bootm.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib32/bootm.c b/arch/arm/lib32/bootm.c
> index d64e705c40..971ebee8ac 100644
> --- a/arch/arm/lib32/bootm.c
> +++ b/arch/arm/lib32/bootm.c
> @@ -104,11 +104,24 @@ static int get_kernel_addresses(size_t image_size,
>         spacing = SZ_1M;
>
>         if (*load_address == UIMAGE_INVALID_ADDRESS) {
> +               unsigned long mem_end = mem_start + mem_size - 1;
> +               unsigned long kaddr;
> +
>                 /*
>                  * Place the kernel at an address where it does not need to
>                  * relocate itself before decompression.
>                  */
> -               *load_address = mem_start + image_decomp_size;
> +               kaddr = mem_start + image_decomp_size;
> +
> +               /*
> +                * Make sure we do not place the image past the end of the
> +                * available memory.
> +                */
> +               if (kaddr + image_size + spacing >= mem_end)
> +                       kaddr = mem_end - image_size - spacing;
> +
> +               *load_address = PAGE_ALIGN_DOWN(kaddr);
> +
>                 if (verbose)
>                         printf("no OS load address, defaulting to 0x%08lx\n",
>                                 *load_address);
> --
> 2.25.1
>
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox