From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Subject: Re: [PATCH 3/3] GUI: Add fbtest command
Date: Thu, 23 Jun 2016 20:18:34 -0700 [thread overview]
Message-ID: <CAHQ1cqED6uU83tqqSu3NFx2a50G7DNm2WVOUKfiMnDmATJ1AYQ@mail.gmail.com> (raw)
In-Reply-To: <20160622135735.67d30c13d9e86d8681162a22@gmail.com>
>
> the int_sqrt() function is defined in the drivers/video/edid.c file.
> To use it we have to keep CONFIG_DRIVER_VIDEO_EDID enabled.
> But I have see no measures on enabling CONFIG_DRIVER_VIDEO_EDID in your patch.
> Have I missed something?
Nope, I missed this function and forgot to deal with it properly.
>
> Can we move int_sqrt() in a separate C library file,
> so edid.c and fbtest.c can both use it?
Absolutely, will fix in v2
Thanks,
Andrey
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-06-24 3:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 4:39 [PATCH 1/3] GUI: Add a function to draw solid rectangles Andrey Smirnov
2016-06-22 4:39 ` [PATCH 2/3] GUI: Add code to draw simple graphics Andrey Smirnov
2016-06-23 7:30 ` Holger Schurig
2016-06-24 4:57 ` Andrey Smirnov
2016-06-22 4:39 ` [PATCH 3/3] GUI: Add fbtest command Andrey Smirnov
2016-06-22 10:49 ` Antony Pavlov
2016-06-24 4:50 ` Andrey Smirnov
2016-06-22 10:57 ` Antony Pavlov
2016-06-24 3:18 ` Andrey Smirnov [this message]
2016-06-23 6:22 ` Sascha Hauer
2016-06-24 3:21 ` Andrey Smirnov
2016-06-23 7:31 ` Holger Schurig
2016-06-23 9:28 ` Sascha Hauer
2016-06-24 4:49 ` Andrey Smirnov
2016-06-23 7:28 ` [PATCH 1/3] GUI: Add a function to draw solid rectangles Holger Schurig
2016-06-24 5:00 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQ1cqED6uU83tqqSu3NFx2a50G7DNm2WVOUKfiMnDmATJ1AYQ@mail.gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox