From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-yw0-x22a.google.com ([2607:f8b0:4002:c05::22a]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bGHdv-00041M-Sk for barebox@lists.infradead.org; Fri, 24 Jun 2016 03:18:56 +0000 Received: by mail-yw0-x22a.google.com with SMTP id v77so89452404ywg.0 for ; Thu, 23 Jun 2016 20:18:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160622135735.67d30c13d9e86d8681162a22@gmail.com> References: <1466570369-1950-1-git-send-email-andrew.smirnov@gmail.com> <1466570369-1950-3-git-send-email-andrew.smirnov@gmail.com> <20160622135735.67d30c13d9e86d8681162a22@gmail.com> From: Andrey Smirnov Date: Thu, 23 Jun 2016 20:18:34 -0700 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] GUI: Add fbtest command To: Antony Pavlov Cc: "barebox@lists.infradead.org" , Andrey Gusakov > > the int_sqrt() function is defined in the drivers/video/edid.c file. > To use it we have to keep CONFIG_DRIVER_VIDEO_EDID enabled. > But I have see no measures on enabling CONFIG_DRIVER_VIDEO_EDID in your patch. > Have I missed something? Nope, I missed this function and forgot to deal with it properly. > > Can we move int_sqrt() in a separate C library file, > so edid.c and fbtest.c can both use it? Absolutely, will fix in v2 Thanks, Andrey _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox