mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>, pza@pengutronix.de
Subject: Re: [PATCH v2 0/5] clk: imx6: work around LDB hang caused by ERR009219
Date: Sun, 26 May 2019 14:59:51 -0700	[thread overview]
Message-ID: <CAHQ1cqEY0wCXTjEmSuNjdzB54zRO1RB8n4BMji9hewTEWg9SFA@mail.gmail.com> (raw)
In-Reply-To: <20190521155626.9906-1-a.fatoum@pengutronix.de>

On Tue, May 21, 2019 at 8:56 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> Short version:
>
> barebox always reparents the ldb_di[01] clocks to pll5_video_div.
> Due to a hardware erratum, this can trigger a glitch that causes
> LDB lock up.
>
> Thus:
>
> 1) remove the automatic reparenting, like the kernel now does and
>    mark the affected clocks read only, so assigned-clock-parents
>    can't affect them
> 2) parse assigned-clock-parents in the clk-imx6 code as well, but
>    there use a convoluted non-glitchy work around to apply them
>
> Long version available alongside v1 here:
> https://www.spinics.net/lists/u-boot-v2/msg37658.html;
> and in the commit messages of the patches.
>
> Changes since v2:
>  - reordered/squashed commits after discussion with Sascha and Phillip
>  - removed superfluous comment
>  - add MUX_READ_ONLY at the correct place in the MUX_READ_ONLY arguments
>
> Except for the last two, the total diff, is exactly the same
> as v1's.
>
>
> Ahmad Fatoum (2):
>   clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div)
>   clk: imx6: define an enum for ldb mux inputs
>
> Fabio Estevam (1):
>   clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK
>
> Philipp Zabel (2):
>   clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only
>   clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and
>     mmdc_ch1_axi_podf
>
>  drivers/clk/imx/clk-imx6.c | 320 +++++++++++++++++++++++++++++++++++--
>  drivers/clk/imx/clk.h      |   8 +
>  2 files changed, 312 insertions(+), 16 deletions(-)
>

Tested this on non 6Q+ RDU2, seems to work as expected when the whole
series is applied.

Tested-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2019-05-26 22:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 15:56 Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 1/5] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-23 10:28     ` Ahmad Fatoum
2019-05-26 21:55   ` Andrey Smirnov
2019-05-27  6:29     ` Ahmad Fatoum
2019-05-27  6:50       ` Andrey Smirnov
2019-05-27  7:23         ` Ahmad Fatoum
2019-05-27  7:28           ` Andrey Smirnov
2019-05-27  7:49             ` Ahmad Fatoum
2019-05-27  8:02               ` Andrey Smirnov
2019-05-27  9:19                 ` Ahmad Fatoum
2019-05-27  7:25         ` Andrey Smirnov
2019-05-27  7:39           ` Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 2/5] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-27  7:01   ` Andrey Smirnov
2019-05-27  7:38     ` Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 3/5] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-21 15:56 ` [PATCH v2 4/5] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Ahmad Fatoum
2019-05-23 10:03   ` Philipp Zabel
2019-05-26 21:58   ` Andrey Smirnov
2019-05-27  7:04   ` Andrey Smirnov
2019-05-21 15:56 ` [PATCH v2 5/5] clk: imx6: define an enum for ldb mux inputs Ahmad Fatoum
2019-05-23 10:03   ` Philipp Zabel
2019-05-23 10:35     ` Ahmad Fatoum
2019-05-26 21:59 ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqEY0wCXTjEmSuNjdzB54zRO1RB8n4BMji9hewTEWg9SFA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=pza@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox