From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ig0-x244.google.com ([2607:f8b0:4001:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aQm3f-00069N-3Y for barebox@lists.infradead.org; Wed, 03 Feb 2016 01:16:35 +0000 Received: by mail-ig0-x244.google.com with SMTP id ik10so1686267igb.1 for ; Tue, 02 Feb 2016 17:16:14 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1454455837.18531.37.camel@rtred1test09.kymeta.local> References: <2936535.PfmXjTYsqy@dabox> <1454455837.18531.37.camel@rtred1test09.kymeta.local> Date: Tue, 2 Feb 2016 17:16:14 -0800 Message-ID: From: Andrey Smirnov List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v4] Terasic DE0-Nano-SoC: add support To: Trent Piepho Cc: "barebox@lists.infradead.org" , Steffen Trumtrar , Tim Sander On Tue, Feb 2, 2016 at 3:30 PM, Trent Piepho wrote: > On Mon, 2016-02-01 at 11:08 -0800, Andrey Smirnov wrote: >> On Mon, Feb 1, 2016 at 8:09 AM, Tim Sander wrote: > >> > + >> > + if (IS_ENABLED(CONFIG_PHYLIB)) >> > + phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, phy_fixup); >> >> I don't think this code is correct. To the best of my knowledge, both >> Atlas and DE0-Nano version of the board come with KSZ9031 as a PHY, >> which requires different fixup. See arm/boards/tqma6x/board.c for >> example. > > I think all the fixups for the micrel phys should probably be replaced > with device tree properties. If you look in drivers/net/phy/micrel.c, > ksz9031_config_init() will read skew properties from the DT and program > the phy that way. This would make it easier to use the phy DT > properties already in the Linux dts files. > I haven't thought about that, that does sound like a better idea. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox