mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v4 10/10] ARM: i.MX: Add support for ZII RDU1 board
Date: Fri, 29 Jun 2018 11:30:18 -0700	[thread overview]
Message-ID: <CAHQ1cqEwMVy3+rQdVSeuy9qAxb2k7Bkb6vZEoeFLN4G2M5VOvg@mail.gmail.com> (raw)
In-Reply-To: <20180629065702.ia6uues5eru62asv@pengutronix.de>

On Thu, Jun 28, 2018 at 11:57 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> Hi Andrey,
>
> On Wed, Jun 27, 2018 at 09:54:36PM -0700, Andrey Smirnov wrote:
> > +#include <common.h>
> > +#include <init.h>
> > +#include <mach/bbu.h>
> > +#include <libfile.h>
> > +#include <mach/imx5.h>
> > +
> > +#define ZII_RDU1_DATAFLASH           "/dev/dataflash0"
> > +#define ZII_RDU1_DATAFLASH_BAREBOX   ZII_RDU1_DATAFLASH ".barebox"
> > +
> > +/**
> > + * zii_rdu1_bbu_spi_update - RDU1 specific BBU handler
> > + *
> > + * @handler: BBU handler pointer passed down by BBU framework
> > + * @data:    BBU data pointer passed down by BBU framework
> > + *
> > + * RDU1 design chose to use first page of the onboard dataflash to
> > + * store vendor board-specific paramters, which means it needs to be
> > + * left intact. However this is problematic because regular ARM
> > + * barebox images contain a 1K preamble and are expected to be placed
> > + * starting at offset zero.
>
> Actually I think that this case is not that unusual. We already keep a
> partition table in that area in case of MMC devices. This code will need
> adjustments anyway when with i.MX8 we finally have enough space in the
> beginning of the device to support GPTs. How about the patch I just sent
> out which simply generalizes and exports the existing KEEP_DOSPART flag?
>
> Sorry for not looking earlier at this issue.
>
> I have merged the patch together with the RDU1 support into next. Please
> let me know if ou are happy with that and if it works of course.
>

I'll give it a try and report back shortly.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-06-29 18:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28  4:54 [PATCH v4 00/10] ZII RDU1 support Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 01/10] mtd: mtd_dataflash: Don't print bogus command values for READs Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 02/10] common: clock: Sample time before poller_call() Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 03/10] ARM: babbage: Make PMIC initialization shareable Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 04/10] bbu: Make bbu_find_handler_by_device() public Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 05/10] ARM: i.MX: bbu: Make imx_bbu_internal_v1_update() public Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 06/10] ARM: i.MX: Move i.MX header definitions to mach-imx Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 07/10] filtype: Add code to detect i.MX image v1 Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 08/10] ARM: i.MX: bbu: Allow plain i.MX v1 images as a special case Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 09/10] ARM: i.MX: bbu: Make struct imx_internal_bbu_handler public Andrey Smirnov
2018-06-28  4:54 ` [PATCH v4 10/10] ARM: i.MX: Add support for ZII RDU1 board Andrey Smirnov
2018-06-29  6:57   ` Sascha Hauer
2018-06-29 18:30     ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqEwMVy3+rQdVSeuy9qAxb2k7Bkb6vZEoeFLN4G2M5VOvg@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox