mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
	Raphael Poggi <poggi.raph@gmail.com>,
	pza@pengutronix.de
Subject: Re: [PATCH v2 1/5] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div)
Date: Mon, 27 May 2019 00:28:32 -0700	[thread overview]
Message-ID: <CAHQ1cqF8R9eN1rosQ8oh2N284VyQYrw1Ynxaykks_o9bKj+Ttw@mail.gmail.com> (raw)
In-Reply-To: <b7c639aa-3afc-c000-ad3c-4aa479a60804@pengutronix.de>

On Mon, May 27, 2019 at 12:23 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> Hello,
>
> On 27/5/19 08:50, Andrey Smirnov wrote:
> > On Sun, May 26, 2019 at 11:29 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> >>
> >> Hello Andrey,
> >>
> >> On 26/5/19 23:55, Andrey Smirnov wrote:
> >>> On Tue, May 21, 2019 at 8:56 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> >>>>
> >>> This particular patch does break a non 6Q+ version of RDU2,  but the
> >>> follow up ones in the series fix it, so it seems that no action is
> >>> really necessary on my part.
> >>
> >> The reparenting removed in this patch isn't reinstated by the rest of the series.
> >> They merely apply parentage expressed in the device tree in a glitch-free manner.
> >>
> >> As both barebox and kernel imx6qdl-zii-rdu2.dtsi lack the relevant
> >> assigned-clock-parents snippet, I am not sure what it is this patch broke that the
> >> follow-up ones fixed?
> >
> > Not sure, will investigate.
>
> Ok.
>
> >
> >>
> >> Generally, affected boards have been broken since day 1, because the LVDS output
> >> would've locked up every blue moon or so. If this patch breaks them, they're just
> >> more reliably broken. :-)
> >>
> >
> > There's a world of difference between not working every once in a blue
> > moon and not working from a first boot.
>
> Ye, the latter one can be dealt with on-the-spot. The other is much more costly to
> fix.
>

Here's a different perspective: If you needed to make an urgent phone
call, would you rather you phone didn't work every once in a blue moon
or be broken for the get go?

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-05-27  7:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 15:56 [PATCH v2 0/5] clk: imx6: work around LDB hang caused by ERR009219 Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 1/5] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-23 10:28     ` Ahmad Fatoum
2019-05-26 21:55   ` Andrey Smirnov
2019-05-27  6:29     ` Ahmad Fatoum
2019-05-27  6:50       ` Andrey Smirnov
2019-05-27  7:23         ` Ahmad Fatoum
2019-05-27  7:28           ` Andrey Smirnov [this message]
2019-05-27  7:49             ` Ahmad Fatoum
2019-05-27  8:02               ` Andrey Smirnov
2019-05-27  9:19                 ` Ahmad Fatoum
2019-05-27  7:25         ` Andrey Smirnov
2019-05-27  7:39           ` Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 2/5] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-27  7:01   ` Andrey Smirnov
2019-05-27  7:38     ` Ahmad Fatoum
2019-05-21 15:56 ` [PATCH v2 3/5] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Ahmad Fatoum
2019-05-23 10:01   ` Philipp Zabel
2019-05-21 15:56 ` [PATCH v2 4/5] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Ahmad Fatoum
2019-05-23 10:03   ` Philipp Zabel
2019-05-26 21:58   ` Andrey Smirnov
2019-05-27  7:04   ` Andrey Smirnov
2019-05-21 15:56 ` [PATCH v2 5/5] clk: imx6: define an enum for ldb mux inputs Ahmad Fatoum
2019-05-23 10:03   ` Philipp Zabel
2019-05-23 10:35     ` Ahmad Fatoum
2019-05-26 21:59 ` [PATCH v2 0/5] clk: imx6: work around LDB hang caused by ERR009219 Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqF8R9eN1rosQ8oh2N284VyQYrw1Ynxaykks_o9bKj+Ttw@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    --cc=pza@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox