From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] arm/cpu/start.c: Distil some common code in __start().
Date: Fri, 30 Oct 2015 09:16:45 -0700 [thread overview]
Message-ID: <CAHQ1cqFFKvu3V_eJy31nbTKqwX3mtKgQmZKiDfYoY22_=wVE9A@mail.gmail.com> (raw)
In-Reply-To: <20151030072007.GY25308@pengutronix.de>
>
> Previously we knew that the pointer barebox_arm_machine() works on is a
> machine type entry and we knew that the pointer returned from
> barebox_arm_boot_dtb() is a dtb. With this patch both are share the same
> pointer so we would have to check if the result returned from
> barebox_arm_boot_dtb() is actually a dtb. That's not so nice.
That is only partially true. The code before this patch assigned the
value of `boarddata` to `barebox_boarddata` unconditionally before it
did any checks of the contents validity, so there were no real
guarantees about barebox_arm_machine().
And we can add those checks to the code of barebox_arm_machine() and
barebox_arm_boot_dtb() and restore the original semantics.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-30 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 18:34 [PATCH v2] ARM: Add support for semihosting Andrey Smirnov
2015-10-28 18:34 ` [PATCH v2 1/2] arm/cpu/start.c: Distil some common code in __start() Andrey Smirnov
2015-10-30 7:20 ` Sascha Hauer
2015-10-30 16:16 ` Andrey Smirnov [this message]
2015-10-28 18:34 ` [PATCH v2 2/2] arm/cpu: Avoid multiple definitions of barebox_arm_entry Andrey Smirnov
2015-10-30 7:10 ` [PATCH v2] ARM: Add support for semihosting Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqFFKvu3V_eJy31nbTKqwX3mtKgQmZKiDfYoY22_=wVE9A@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox