mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 09/17] of: Port latest of_device_make_bus_id() implementation
Date: Wed, 10 Oct 2018 09:54:06 -0700	[thread overview]
Message-ID: <CAHQ1cqFMMOOg8KsR7wb01rchH2mQ0xxDQS8YtF2H=ww0VRvHew@mail.gmail.com> (raw)
In-Reply-To: <1539190319.3515.48.camel@pengutronix.de>

On Wed, Oct 10, 2018 at 9:52 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Hi Andrey,
>
> Am Dienstag, den 09.10.2018, 10:37 -0700 schrieb Andrey Smirnov:
> > Code implementing of_device_make_bus_id() in Barebox uses rather old
> > implementation from Linux kernel and has a very significan limitation
> > in that it will produce identical names for different DT nodes that
> > happen to have the same node name as well as "reg" property.
> >
> > > One such example, that tirggered this change, is "switch@0" nodes that
> > can be found in dts/src/arm/vf610-zii-dev-rev-c.dts
> >
> > This commit replaces original code with the current Linux kernel
> > implementation that traverses DT hierarchy from leaf node to its root
> > concatenating node names in the process.
>
> I think this change is what is breaking the imx_thermal driver here.
>
> This is a bad interaction between the AIODEV framework using the
> hwdev->device_node->name as the device name for the aoidev and the
> parent device getting the same name with this change. Before this
> change the tempmon platform device (which doesn't has an address by
> itself) would get a made up bus_no_reg_magic appended.
>
> Due to both devices having the same name, the device registration for
> the aiodev now fails. I've fixed it locally by not using the node name
> in the AIODEV framework, but you may prefer to fix this differently.
> Something to keep in mind for v3 of this series.
>

Thanks for finding this out! Added on my things to fix in v3 list.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-10 16:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 17:37 [PATCH v2 00/17] MV88E6xxx switch family support Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 01/17] ARM: Do not expose ARMv8 functions on ARMv7 Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 02/17] clocksource: Add ARM global timer support Andrey Smirnov
2018-10-11  8:28   ` Sascha Hauer
2018-10-09 17:37 ` [PATCH v2 03/17] VFxxx: Select CLOCKSOURCE_ARM_GLOBAL_TIMER Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 04/17] i.MX: Move GPT driver to drivers/clocksource Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 05/17] clocksource: Introduce ARCH_HAS_IMX_GPT Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 06/17] of: Demote "Bad cell count for" to debug Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 07/17] drivers: Introduce dev_set_name() Andrey Smirnov
2018-10-10  2:57   ` Andrey Smirnov
2018-10-11  8:56     ` Sascha Hauer
2018-10-12  2:01       ` Andrey Smirnov
2018-10-10  9:41   ` Lucas Stach
2018-10-10 15:33     ` Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 08/17] linux: string: Port kbasename() Andrey Smirnov
2018-10-11  8:31   ` Sascha Hauer
2018-10-13 20:47     ` Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 09/17] of: Port latest of_device_make_bus_id() implementation Andrey Smirnov
2018-10-10 16:51   ` Lucas Stach
2018-10-10 16:54     ` Andrey Smirnov [this message]
2018-10-09 17:37 ` [PATCH v2 10/17] mdio_bus: Fix documentation for mdio_bus_match() Andrey Smirnov
2018-10-09 17:37 ` [PATCH v2 11/17] include: linux: phy: Add missing PHY_INTERFACE_* constants Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 12/17] include: linux: ethtool: Add missing *_UNKNOWN constants Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 13/17] net: phy: Check phy_mask in get_phy_device() Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 14/17] mdio_bus: Allow for non PHY-devices on MDIO buses Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 15/17] net: phy: Add basic driver for MV88E6XXX switches from Marvell Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 16/17] net: phy: mv88e6xxx: Port EEPROM support code Andrey Smirnov
2018-10-09 17:38 ` [PATCH v2 17/17] net: phy: mv88e6xxx: Add support for MAC ports Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqFMMOOg8KsR7wb01rchH2mQ0xxDQS8YtF2H=ww0VRvHew@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox