mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] nvmem: Introduce nvmem_cell_get_and_read()
Date: Wed, 27 Jun 2018 09:57:51 -0700	[thread overview]
Message-ID: <CAHQ1cqFQJiLezTDhmDfGmNqF4NkY5uQgs6ODaA5-vEjP1KN-wA@mail.gmail.com> (raw)
In-Reply-To: <1530090334.22468.15.camel@pengutronix.de>

On Wed, Jun 27, 2018 at 2:05 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Am Dienstag, den 26.06.2018, 20:58 -0700 schrieb Andrey Smirnov:
> > Introduce nvmem_cell_get_and_read() that combines getting a NVMEM cell
> > by name and reading its contents.
> >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >  drivers/nvmem/core.c           | 23 +++++++++++++++++++++++
> >  include/linux/nvmem-consumer.h | 10 ++++++++++
> >  2 files changed, 33 insertions(+)
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index 53b934bb3..c785de125 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -750,3 +750,26 @@ int nvmem_device_write(struct nvmem_device *nvmem,
> > >     return bytes;
> >  }
> >  EXPORT_SYMBOL_GPL(nvmem_device_write);
> > +
> > +void *nvmem_cell_get_and_read(struct device_node *np, const char *cell_name,
> > > +                         size_t bytes)
> > +{
> > > +   struct nvmem_cell *cell;
> > > +   void *value;
> > > +   size_t len;
> > +
> > > +   cell = of_nvmem_cell_get(np, cell_name);
> > > +   if (IS_ERR(cell))
> > > +           return cell;
> > +
> > > +   value = nvmem_cell_read(cell, &len);
> > > +   if (!IS_ERR(value) && len != bytes) {
> > > +           kfree(value);
> > > +           value = ERR_PTR(-EINVAL);
> > > +   }
> > +
> > > +   nvmem_cell_put(cell);
> > +
> > > +   return value;
> > +}
> > +EXPORT_SYMBOL_GPL(nvmem_cell_get_and_read);
> > \ No newline at end of file
>
> I'm sure you are tired by me nitpicking on this. ;)

Oh I totally left it there on purpose to know if you've read my patch or not ;-)

In all seriousness, will fix in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-06-27 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  3:58 Andrey Smirnov
2018-06-27  3:58 ` [PATCH 2/2] ARM: rdu2: Fetch MAC address info from RAVE SP EEPROM Andrey Smirnov
2018-06-27  9:05 ` [PATCH 1/2] nvmem: Introduce nvmem_cell_get_and_read() Lucas Stach
2018-06-27 16:57   ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqFQJiLezTDhmDfGmNqF4NkY5uQgs6ODaA5-vEjP1KN-wA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox