Re: [PATCH 1/2] nvmem: Introduce nvmem_cell_get_and_read()

[Andrey Smirnov <andrew.smirnov@gmail.com>]

On Wed, Jun 27, 2018 at 2:05 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Am Dienstag, den 26.06.2018, 20:58 -0700 schrieb Andrey Smirnov:
> > Introduce nvmem_cell_get_and_read() that combines getting a NVMEM cell
> > by name and reading its contents.
> >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >  drivers/nvmem/core.c           | 23 +++++++++++++++++++++++
> >  include/linux/nvmem-consumer.h | 10 ++++++++++
> >  2 files changed, 33 insertions(+)
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index 53b934bb3..c785de125 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -750,3 +750,26 @@ int nvmem_device_write(struct nvmem_device *nvmem,
> > >     return bytes;
> >  }
> >  EXPORT_SYMBOL_GPL(nvmem_device_write);
> > +
> > +void *nvmem_cell_get_and_read(struct device_node *np, const char *cell_name,
> > > +                         size_t bytes)
> > +{
> > > +   struct nvmem_cell *cell;
> > > +   void *value;
> > > +   size_t len;
> > +
> > > +   cell = of_nvmem_cell_get(np, cell_name);
> > > +   if (IS_ERR(cell))
> > > +           return cell;
> > +
> > > +   value = nvmem_cell_read(cell, &len);
> > > +   if (!IS_ERR(value) && len != bytes) {
> > > +           kfree(value);
> > > +           value = ERR_PTR(-EINVAL);
> > > +   }
> > +
> > > +   nvmem_cell_put(cell);
> > +
> > > +   return value;
> > +}
> > +EXPORT_SYMBOL_GPL(nvmem_cell_get_and_read);
> > \ No newline at end of file
>
> I'm sure you are tired by me nitpicking on this. ;)

Oh I totally left it there on purpose to know if you've read my patch or not ;-)

In all seriousness, will fix in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox