Re: [PATCH] hab: Print events on info command.

[Andrey Smirnov <andrew.smirnov@gmail.com>]

On Thu, Oct 4, 2018 at 12:05 AM Denis OSTERLAND
<denis.osterland@diehl.com> wrote:
>
> From: Denis Osterland <Denis.Osterland@diehl.com>
>
> This patch calls *_hab_get_status function as part of hab info command.
> This function works only if MMU is disabled.
>
> Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
> ---
>  commands/hab.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/commands/hab.c b/commands/hab.c
> index 0d7ee8e76..9027b7cb5 100644
> --- a/commands/hab.c
> +++ b/commands/hab.c
> @@ -72,6 +72,18 @@ static int do_hab(int argc, char *argv[])
>                 else
>                         printf("devel mode\n");
>
> +#ifdef CONFIG_MMU
> +               printf("Disable MMU to access HAB API!\n");
> +#else

Minor suggestion: using IS_ENABLED() might be better since it'll make
the code visible to the compiler regardless of CONFIG_MMU, which might
help better to prevent accidental bitrot (not very likely in this
particular instance, but still).

> +# if defined(CONFIG_ARCH_IMX6)
> +               imx6_hab_get_status();
> +# elif defined(CONFIG_ARCH_IMX28)
> +               imx28_hab_get_status();
> +# elif defined(CONFIG_ARCH_IMX25)
> +               imx25_hab_get_status();
> +# endif

Should this check be done at runtime with cpu_is_*()? I'd imagine that
it would be possible to create a multi-board image that supports both
i.MX25 and and i.MX6.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox