From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtiqV-0002Fp-LB for barebox@lists.infradead.org; Wed, 13 Feb 2019 00:56:17 +0000 Received: by mail-wr1-x441.google.com with SMTP id q18so548579wrx.9 for ; Tue, 12 Feb 2019 16:56:15 -0800 (PST) MIME-Version: 1.0 References: <1549898200-32688-1-git-send-email-t.remmet@phytec.de> <1549898200-32688-2-git-send-email-t.remmet@phytec.de> In-Reply-To: From: Andrey Smirnov Date: Tue, 12 Feb 2019 16:56:02 -0800 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver To: Teresa Remmet Cc: Barebox List On Tue, Feb 12, 2019 at 5:13 AM Teresa Remmet wrote: > > Hello Andrey, > > Am Montag, den 11.02.2019, 18:57 -0800 schrieb Andrey Smirnov: > > On Mon, Feb 11, 2019 at 7:16 AM Teresa Remmet > > wrote: > > > > > > Adds minimal support for the sysc interconnect target module found > > > on many TI SoCs. With this device tree includes have been > > > rearagned. > > > We need the driver to probe the child devices of the bus. > > > > > > Signed-off-by: Teresa Remmet > > > --- > > > > > > + > > > +static const struct of_device_id sysc_match_table[] = { > > > + { .compatible = "simple-bus", }, > > > + { /* sentinel */ }, > > > +}; > > > + > > > +static int ti_sysc_probe(struct device_d *dev) > > > +{ > > > + int ret; > > > + > > > + ret = of_platform_populate(dev->device_node, > > > sysc_match_table, dev); > > > > Is sysc_match_table really necessary? AFAIK that argument can be NULL > > unless on of the child nodes needs to be treated like a platform bus > > as well. > > My first attempted was using NULL but this does not work. As for > example the pinmux node (pinmux@800) is child of a simple-bus. And the > simple-bus itself is a child of a ti-sysc node. See dts/src/arm/am33xx- > l4.dtsi. > The kernel does it the same way. > Ah, I see, your use-case does require child nodes to be treated as a platform bus. FWIW, there's also globally visible of_default_bus_match_table that can probably replace sysc_match_table. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox