From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oa0-f49.google.com ([209.85.219.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1UA20u-0005Nw-QA for barebox@lists.infradead.org; Mon, 25 Feb 2013 17:38:57 +0000 Received: by mail-oa0-f49.google.com with SMTP id j6so3220319oag.22 for ; Mon, 25 Feb 2013 09:38:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20130225172143.GD10258@game.jcrosoft.org> References: <1361435514-4474-1-git-send-email-fabio.porcedda@gmail.com> <20130225120236.GB10258@game.jcrosoft.org> <20130225131604.GC10258@game.jcrosoft.org> <20130225172143.GD10258@game.jcrosoft.org> From: Fabio Porcedda Date: Mon, 25 Feb 2013 18:38:35 +0100 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] fix compiler warnings: use puts() instead of printf() To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org, Vicente On Mon, Feb 25, 2013 at 6:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 16:27 Mon 25 Feb , Fabio Porcedda wrote: >> On Mon, Feb 25, 2013 at 2:16 PM, Jean-Christophe PLAGNIOL-VILLARD >> wrote: >> > On 13:23 Mon 25 Feb , Fabio Porcedda wrote: >> >> On Mon, Feb 25, 2013 at 1:02 PM, Jean-Christophe PLAGNIOL-VILLARD >> >> wrote: >> >> > On 09:31 Thu 21 Feb , Fabio Porcedda wrote: >> >> >> Use puts() because printf() isn't necessary, >> >> >> to fix the following compiler warnings: >> >> >> >> >> >> /barebox/common/menu.c: In function =91menu_show=92: >> >> >> /barebox/common/menu.c:277:4: warning: format not a string literal= and no format arguments [-Wformat-security] >> >> >> >> >> >> /barebox/scripts/omap4_usbboot.c: In function =91read_asic_id=92: >> >> >> /barebox/scripts/omap4_usbboot.c:101:3: warning: format not a stri= ng literal and no format arguments [-Wformat-security] >> >> > >> >> > Sascha revert this please this add a "\n" that we do not want >> >> > specially on the menu >> >> >> >> I've already sent a patch to fix the newline problem and the warning = too. >> >> Reverting the patch doesn't fix the warning. >> > the patch is wrong we revert you send the write one >> >> I understand that the patch is wrong but the patch cannot be simply >> reverted because in master there is already a partial fix for it: >> "OMAP4 USB BOOT: remove double line endings". >> >> Only half of the patch can be reverted but instead of reverting it we >> can fix it. >> I've already sent the patch to fix the remaining part: >> " menu: fix remove superfluous newline: change puts() -> printf("%s, )" >> >> What do you think about that patch? > > I'm sorry NACK this break git bisect not acceptable > > for just warnings You are right but the patch is already in branch master: http://git.pengutronix.de/?p=3Dbarebox.git;a=3Dcommit;h=3D638f91bd166fe4aa8= ee7c046c6102dab6d44ee0b Only a git rebase -i can change that, but a rebase is not good for master. Best regards Fabio Porcedda > Best Regards, > J. >> >> Best regards >> Fabio Porcedda >> >> > Best Regards, >> > J. >> >> >> >> Best regards >> >> Fabio Porcedda >> >> >> >> > Best Regards, >> >> > J. >> >> >> >> >> >> Signed-off-by: Fabio Porcedda >> >> >> Cc: Jean-Christophe PLAGNIOL-VILLARD >> >> >> Cc: Vicente >> >> >> --- >> >> >> common/menu.c | 2 +- >> >> >> scripts/omap4_usbboot.c | 2 +- >> >> >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> >> >> >> >> diff --git a/common/menu.c b/common/menu.c >> >> >> index ce93838..30dced7 100644 >> >> >> --- a/common/menu.c >> >> >> +++ b/common/menu.c >> >> >> @@ -274,7 +274,7 @@ int menu_show(struct menu *m) >> >> >> printf("Auto Select in"); >> >> >> } else { >> >> >> auto_display_len =3D strlen(m->auto_display); >> >> >> - printf(m->auto_display); >> >> >> + puts(m->auto_display); >> >> >> } >> >> >> printf(" %2d", countdown--); >> >> >> } >> >> >> diff --git a/scripts/omap4_usbboot.c b/scripts/omap4_usbboot.c >> >> >> index 8c5775d..34e53c0 100644 >> >> >> --- a/scripts/omap4_usbboot.c >> >> >> +++ b/scripts/omap4_usbboot.c >> >> >> @@ -98,7 +98,7 @@ int read_asic_id(struct usb_handle *usb) >> >> >> sprintf(line+4+j*3, "%02X ", id[i+j]); >> >> >> line[4+j*3+0] =3D '\n'; >> >> >> line[4+j*3+1] =3D 0; >> >> >> - printf(line); >> >> >> + puts(line); >> >> >> } >> >> >> ret =3D 0; >> >> >> for (i =3D 1, j =3D 0; i < sizeof(id) && j < id[0]; i +=3D 2= +id[i+1], j++) { >> >> >> -- >> >> >> 1.8.1.1 >> >> >> >> >> >> >> >> >> >> >> -- >> >> Fabio Porcedda >> >> >> >> -- >> Fabio Porcedda -- Fabio Porcedda _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox