From: Franck Jullien <franck.jullien@gmail.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] common/partitions.c: make use of is_fat_or_mbr
Date: Thu, 11 Oct 2012 22:44:43 +0200 [thread overview]
Message-ID: <CAJfOKBwfu3NvZnny8vRrWi24BUuMF1MHXW0jy0CnqpKFsoJ6jA@mail.gmail.com> (raw)
In-Reply-To: <1349987291-11714-2-git-send-email-franck.jullien@gmail.com>
2012/10/11 Franck Jullien <franck.jullien@gmail.com>:
> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> ---
> common/partitions.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/common/partitions.c b/common/partitions.c
> index 0e42937..85bca32 100644
> --- a/common/partitions.c
> +++ b/common/partitions.c
> @@ -28,6 +28,7 @@
> #include <asm/unaligned.h>
> #include <disks.h>
> #include <dma.h>
> +#include <filetype.h>
>
> struct partition {
> uint64_t first_sec;
> @@ -85,7 +86,7 @@ static void __maybe_unused try_dos_partition(struct block_device *blk,
> goto on_error;
> }
>
> - if ((buffer[510] != 0x55) || (buffer[511] != 0xAA)) {
> + if(is_fat_or_mbr(buffer, NULL) != filetype_mbr) {
Please put a space after "if" :) I resend....
> dev_info(blk->dev, "No partition table found\n");
> goto on_error;
> }
> --
> 1.7.1
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-11 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 20:28 [PATCH 1/2] common/paritions.c: force little endian reads Franck Jullien
2012-10-11 20:28 ` [PATCH 2/2] common/partitions.c: make use of is_fat_or_mbr Franck Jullien
2012-10-11 20:44 ` Franck Jullien [this message]
2012-10-12 8:07 ` [PATCH 1/2] common/paritions.c: force little endian reads Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfOKBwfu3NvZnny8vRrWi24BUuMF1MHXW0jy0CnqpKFsoJ6jA@mail.gmail.com \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox