From: Franck Jullien <franck.jullien@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] openrisc: move ethoc registration to device_initcall
Date: Mon, 12 May 2014 09:49:50 +0200 [thread overview]
Message-ID: <CAJfOKBzmAZxvOVEqSGaReS8-s6W3B0if4OnKC55RL0vLTDZGCA@mail.gmail.com> (raw)
In-Reply-To: <20140512044059.GX5858@pengutronix.de>
2014-05-12 6:40 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Sun, May 11, 2014 at 12:42:04AM +0200, Franck Jullien wrote:
>> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
>> ---
>> arch/openrisc/boards/generic/generic.c | 18 ++++++++++++------
>> 1 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/openrisc/boards/generic/generic.c b/arch/openrisc/boards/generic/generic.c
>> index 9f68007..5c1698d 100644
>> --- a/arch/openrisc/boards/generic/generic.c
>> +++ b/arch/openrisc/boards/generic/generic.c
>> @@ -9,6 +9,18 @@ static struct NS16550_plat serial_plat = {
>> .shift = 0,
>> };
>>
>> +static int openrisc_devices_init(void)
>> +{
>> +#ifdef CONFIG_DRIVER_NET_ETHOC
>> + add_generic_device("ethoc", DEVICE_ID_DYNAMIC, NULL,
>> + OPENRISC_SOPC_ETHOC_BASE, 0x1000,
>> + IORESOURCE_MEM, NULL);
>> +#endif
>> + return 0;
>> +}
>> +
>> +device_initcall(openrisc_devices_init);
>
> What's wrong with the original console_initcall? Does this solve any
> issues?
>
> Sascha
>
It does not solve anything. However, it can lead to errors.
As a matter of fact I have a NOR on my board so I added
add_cfi_flash_device and devfs_add_partition just above the ethoc in
the console_initcall...and it doesn't work (because it's too early in
the boot process).
Anyway, don't apply this for now has I have some problems with
ethernet and it's may be related.
Franck.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-05-12 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 22:42 Franck Jullien
2014-05-12 4:40 ` Sascha Hauer
2014-05-12 7:49 ` Franck Jullien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfOKBzmAZxvOVEqSGaReS8-s6W3B0if4OnKC55RL0vLTDZGCA@mail.gmail.com \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox