mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Денис Орлов" <denorl2009@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: fix clk_round_rate() behaviour
Date: Thu, 19 May 2022 11:12:37 +0300	[thread overview]
Message-ID: <CALHb5ug+DS=F424FDZhbYJgwpPyP27-hCQvyeLQcS7XxmqBEjw@mail.gmail.com> (raw)
In-Reply-To: <20220516090721.GN25578@pengutronix.de>

Hi,

On Mon, 16 May 2022 at 12:07, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> I smell problems with this patch. Which clocks do you have that do not
> have a round_rate hook but still allow to set its rate?

Well, the reason for making this patch was actually the lack of any
output from the clk_set_rate command if there was no set_rate (together
with round_rate) hook set for a given clock. In this case set_rate()
would check round_rate() to be equal to the current rate and leave
without returning an error. But I would like to actually receive some
response about the fact that this clock does not support setting its
rate.
However, I agree with you that this solution may lead to problems.
Maybe instead we should explicitly check in a command whether the given
clock has an appropriate hook set and output some message if this is not
the case. What do you think?

Regards,
Denis

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2022-05-19  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  7:00 Denis Orlov
2022-05-16  9:07 ` Sascha Hauer
2022-05-19  8:12   ` Денис Орлов [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALHb5ug+DS=F424FDZhbYJgwpPyP27-hCQvyeLQcS7XxmqBEjw@mail.gmail.com' \
    --to=denorl2009@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox