From: Trent Piepho <trent.piepho@igorinstitute.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] net: phy: micrel: sync init code for ksz80xx variants with the kernel driver
Date: Thu, 14 Oct 2021 13:32:27 -0700 [thread overview]
Message-ID: <CAMHeXxMuEMF5yuBkxkNHBVNfO6Yk66mw+5++yesqsOOGSGrBeA@mail.gmail.com> (raw)
In-Reply-To: <20211013111951.GD17532@pengutronix.de>
On Wed, Oct 13, 2021 at 4:19 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> On Wed, Oct 13, 2021 at 03:25:17AM -0700, Trent Piepho wrote:
> > On Wed, Oct 13, 2021 at 2:43 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > >
> > > Sync part of barebox micrel driver with the kernel v5.15-rc1.
> > > This change will affect most of by barebox supported 100Mbit/ksz80xx PHY
> > > variants and provide unified devicetree support for LED and clock configuration.
> >
> > I already added LED mode OF support to this driver.
>
> Yes, it was partially incorrect. It attempted to write to not existing or not
> documented register of PHY_ID_KS8737.
That is not true. KS8737 would only attempt to set the led mode bits
if the device tree tries to set the led mode. Since KS8737 does not
have a led mode selection, the device tree should not have this, and
there is no problem.
If you want a device tree validator, then use the yaml dts spec to do
this in the proper way, at build time. The bootloader has the the
most constrained size of any part of a Linux system and is also the
most critical for device start up time. It is the worst possible
place to put a dts validator.
> This is the reason why I prefer to share driver code base with kernel,
> where possible.
You again ignore there are two ways to do this. Make the kernel match
Barebox where the Barebox code is better.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-10-14 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 7:53 [PATCH v2 1/2] include/phy: add driver_data to resume more of kernel code Oleksij Rempel
2021-10-13 7:53 ` [PATCH v2 2/2] net: phy: micrel: sync init code for ksz80xx variants with the kernel driver Oleksij Rempel
2021-10-13 10:25 ` Trent Piepho
2021-10-13 11:19 ` Oleksij Rempel
2021-10-14 20:32 ` Trent Piepho [this message]
2021-10-15 6:36 ` Oleksij Rempel
2021-10-15 7:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMHeXxMuEMF5yuBkxkNHBVNfO6Yk66mw+5++yesqsOOGSGrBeA@mail.gmail.com \
--to=trent.piepho@igorinstitute.com \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox