mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Masahiro YAMADA <yamada.m@jp.panasonic.com>
To: "Jan Lübbe" <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! defaultenv: generate force-built-in (zero) environment file
Date: Thu, 5 Feb 2015 01:09:33 +0900	[thread overview]
Message-ID: <CAMhH57TJPFVBepWVpMPON2MaYyyBtqWz4HD+FMj76qYwO-eRnQ@mail.gmail.com> (raw)
In-Reply-To: <1423060756.4050.78.camel@pengutronix.de>

Hi Jan,


2015-02-04 23:39 GMT+09:00 Jan Lübbe <jlu@pengutronix.de>:
> On Di, 2015-02-03 at 18:45 +0900, Masahiro Yamada wrote:
>> Without this, out-of-tree build (O=option) fails.
>>
>> diff --git a/defaultenv/Makefile b/defaultenv/Makefile
>> index 8a001ec..33e0ece 100644
>> --- a/defaultenv/Makefile
>> +++ b/defaultenv/Makefile
>> @@ -24,7 +24,7 @@ $(obj)/barebox_default_env.h: $(obj)/barebox_default_env$(DEFAULT_COMPRESSION_SU
>>       $(call if_changed,env_h)
>>
>>  quiet_cmd_env_zero = ENVZ    $@
>> -cmd_env_zero = ($(srctree)/scripts/bareboxenv -z $(CONFIG_DEFAULT_ENVIRONMENT_PATH) $@)
>> +cmd_env_zero = ($(objtree)/scripts/bareboxenv -z $(CONFIG_DEFAULT_ENVIRONMENT_PATH) $@)
>
> I adapted this from the same file a few lines above:
> quiet_cmd_env_default = ENV     $@
> cmd_env_default = ($(srctree)/scripts/genenv $(srctree) $(objtree) $@ $(CONFIG_DEFAULT_ENVIRONMENT_PATH))
>
> Why didn't this fail for your?
>

scripts/getenv is a shell script.
It resides in the source directory.


On the other hand, scripts/bareboxenv is a C program
that is compiled from bareboxenv.c.


That's the difference.



-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-02-04 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  9:45 Masahiro Yamada
2015-02-04 11:47 ` Sascha Hauer
2015-02-04 14:39 ` Jan Lübbe
2015-02-04 16:09   ` Masahiro YAMADA [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMhH57TJPFVBepWVpMPON2MaYyyBtqWz4HD+FMj76qYwO-eRnQ@mail.gmail.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=barebox@lists.infradead.org \
    --cc=jlu@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox