mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	Eric Nelson <eric.nelson@boundarydevices.com>
Subject: Re: [PATCH] serial: imx: Fix buggy transmissions when baudrate mismatches
Date: Wed, 28 May 2014 16:57:18 -0300	[thread overview]
Message-ID: <CAOMZO5DUtJu962JEbSBMRQMxVkZDD+rYVmr0Ajgfavx7+qgdww@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5D=SHf19XuptdZTVvn6GGvUEvAcG9RbG9r_g_Z-DZfdsg@mail.gmail.com>

On Thu, May 15, 2014 at 7:05 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Sascha,
>
> On Thu, May 15, 2014 at 6:21 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
>>> --- a/drivers/serial/serial_imx.c
>>> +++ b/drivers/serial/serial_imx.c
>>> @@ -258,7 +258,8 @@ static int imx_serial_getc(struct console_device *cdev)
>>>         while (readl(priv->regs + priv->devtype->uts) & UTS_RXEMPTY);
>>>
>>>         ch = readl(priv->regs + URXD0);
>>> -
>>> +       if (ch >= 0x80)
>>> +               ch = '?';
>>
>> This is not part of the fix, right?
>
> Correct, this is not part of the fix.
>
> This code is just to help reproducing the issue in console, without
> the need of hooking an oscilloscope to the UART pins or inspecting
> directly the UART TX registers.

Any comments, Sascha?

The same fix has also been applied to the kernel:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=b38cb7d2571197b56cefae8967f9db15c9361113

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-05-28 19:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 18:14 Fabio Estevam
2014-05-15 21:21 ` Sascha Hauer
2014-05-15 22:05   ` Fabio Estevam
2014-05-28 19:57     ` Fabio Estevam [this message]
2014-06-02  7:22       ` Sascha Hauer
2014-06-02 10:59         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5DUtJu962JEbSBMRQMxVkZDD+rYVmr0Ajgfavx7+qgdww@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=eric.nelson@boundarydevices.com \
    --cc=fabio.estevam@freescale.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox