From: Holger Schurig <holgerschurig@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 09/10] beautify PHY driver names
Date: Fri, 30 May 2014 11:30:27 +0200 [thread overview]
Message-ID: <CAOpc7mGQ0QPpY06qhQJpxjDPZqa7Uz7CdLrwJrtXRJxLRSBO7g@mail.gmail.com> (raw)
In-Reply-To: <20140530091716.GA13550@omega>
I changed them because (before my patches) the driver list in
"devinfo" looked ugly, with my drvinfo command that one looked ugly.
Those driver names sticked out like a sore thumb.
Now, if I do "diff linux/driver/net/phy/micrel.c
barebox/driver/net/phy/micrel.c", I can see that those files are a bit
similar ... but only a bit. Diff spits out 569 lines of diff output.
And as micrel.c is only 281 lines long, this means that almost no
identical lines are in those two files anyway ... so, the drivers
are following the Linux model, but they are not Linux drivers anyway.
As this is purely cosmetical, I won't fight over it. Or at least not more :-)
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-30 9:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 9:07 [PATCH 00/10] miscelleanous beautification patches Holger Schurig
2014-05-30 9:05 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 01/10] drvlist: factor the driver list out of 'devinfo' Holger Schurig
2014-05-30 9:09 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 02/10] devinfo: reduce indentation Holger Schurig
2014-05-30 9:08 ` Holger Schurig
2014-05-30 9:49 ` Antony Pavlov
2014-05-30 9:07 ` [PATCH 03/10] devinfo: make the output of "devinfo DEVICE" nicer Holger Schurig
2014-05-30 9:07 ` Holger Schurig
2014-06-02 8:19 ` Juergen Borleis
2014-06-02 9:23 ` Holger Schurig
2014-06-02 10:09 ` Juergen Borleis
2014-06-02 10:28 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 04/10] parameters: only show possible enumerations if there are any Holger Schurig
2014-05-30 9:09 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 05/10] net: show enetaddr in lowercase Holger Schurig
2014-05-30 9:07 ` [PATCH 06/10] meminfo: purely cosmetical changes Holger Schurig
2014-05-30 9:43 ` Antony Pavlov
2014-05-30 9:37 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 07/10] misc: upper-case some abbreviations Holger Schurig
2014-05-30 9:07 ` [PATCH 08/10] bootm: beautify output Holger Schurig
2014-05-30 9:06 ` Holger Schurig
2014-05-30 9:07 ` [PATCH 09/10] beautify PHY driver names Holger Schurig
2014-05-30 9:17 ` Alexander Aring
2014-05-30 9:30 ` Holger Schurig [this message]
2014-05-30 10:03 ` Alexander Aring
2014-06-02 6:59 ` Sascha Hauer
2014-05-30 9:07 ` [PATCH 10/10] device drivers: harmonize underscore in " Holger Schurig
2014-06-02 7:16 ` Sascha Hauer
2014-06-02 7:21 ` [PATCH 00/10] miscelleanous beautification patches Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOpc7mGQ0QPpY06qhQJpxjDPZqa7Uz7CdLrwJrtXRJxLRSBO7g@mail.gmail.com \
--to=holgerschurig@gmail.com \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox