* [PATCH] arm: bootm-fip: remove redundant variable declaration
@ 2025-08-25 12:11 Alexander Shiyan
2025-08-26 5:07 ` Sascha Hauer
2025-09-12 6:55 ` Alexander Shiyan
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Shiyan @ 2025-08-25 12:11 UTC (permalink / raw)
To: barebox; +Cc: Alexander Shiyan
Remove shadowed variable declaration inside the loop
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
arch/arm/cpu/bootm-fip.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/cpu/bootm-fip.c b/arch/arm/cpu/bootm-fip.c
index bd176f0645..a50b3f4431 100644
--- a/arch/arm/cpu/bootm-fip.c
+++ b/arch/arm/cpu/bootm-fip.c
@@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
for_each_child_of_node_safe(fconf, tmp, image) {
u64 load_addr;
u32 id;
- int ret;
ret = of_property_read_u32(image, "id", &id);
if (ret)
--
2.38.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: bootm-fip: remove redundant variable declaration
2025-08-25 12:11 [PATCH] arm: bootm-fip: remove redundant variable declaration Alexander Shiyan
@ 2025-08-26 5:07 ` Sascha Hauer
2025-09-12 6:55 ` Alexander Shiyan
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2025-08-26 5:07 UTC (permalink / raw)
To: barebox, Alexander Shiyan
On Mon, 25 Aug 2025 15:11:52 +0300, Alexander Shiyan wrote:
> Remove shadowed variable declaration inside the loop
>
>
Applied, thanks!
[1/1] arm: bootm-fip: remove redundant variable declaration
https://git.pengutronix.de/cgit/barebox/commit/?id=54e2f6bf929d (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: bootm-fip: remove redundant variable declaration
2025-08-25 12:11 [PATCH] arm: bootm-fip: remove redundant variable declaration Alexander Shiyan
2025-08-26 5:07 ` Sascha Hauer
@ 2025-09-12 6:55 ` Alexander Shiyan
2025-09-12 7:49 ` Sascha Hauer
1 sibling, 1 reply; 4+ messages in thread
From: Alexander Shiyan @ 2025-09-12 6:55 UTC (permalink / raw)
To: barebox
ping
пн, 25 авг. 2025 г. в 15:12, Alexander Shiyan <eagle.alexander923@gmail.com>:
>
> Remove shadowed variable declaration inside the loop
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> arch/arm/cpu/bootm-fip.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/cpu/bootm-fip.c b/arch/arm/cpu/bootm-fip.c
> index bd176f0645..a50b3f4431 100644
> --- a/arch/arm/cpu/bootm-fip.c
> +++ b/arch/arm/cpu/bootm-fip.c
> @@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
> for_each_child_of_node_safe(fconf, tmp, image) {
> u64 load_addr;
> u32 id;
> - int ret;
>
> ret = of_property_read_u32(image, "id", &id);
> if (ret)
> --
> 2.38.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: bootm-fip: remove redundant variable declaration
2025-09-12 6:55 ` Alexander Shiyan
@ 2025-09-12 7:49 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2025-09-12 7:49 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Fri, Sep 12, 2025 at 09:55:07AM +0300, Alexander Shiyan wrote:
> ping
The patch already sits in master as 54e2f6bf92 ("arm: bootm-fip:
remove redundant variable declaration")
Sascha
>
> пн, 25 авг. 2025 г. в 15:12, Alexander Shiyan <eagle.alexander923@gmail.com>:
> >
> > Remove shadowed variable declaration inside the loop
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> > ---
> > arch/arm/cpu/bootm-fip.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/cpu/bootm-fip.c b/arch/arm/cpu/bootm-fip.c
> > index bd176f0645..a50b3f4431 100644
> > --- a/arch/arm/cpu/bootm-fip.c
> > +++ b/arch/arm/cpu/bootm-fip.c
> > @@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
> > for_each_child_of_node_safe(fconf, tmp, image) {
> > u64 load_addr;
> > u32 id;
> > - int ret;
> >
> > ret = of_property_read_u32(image, "id", &id);
> > if (ret)
> > --
> > 2.38.2
> >
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-12 7:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-25 12:11 [PATCH] arm: bootm-fip: remove redundant variable declaration Alexander Shiyan
2025-08-26 5:07 ` Sascha Hauer
2025-09-12 6:55 ` Alexander Shiyan
2025-09-12 7:49 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox