mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: boards: Add support for MYIR MYD-AM335X Development Board
Date: Thu, 21 Apr 2022 10:57:33 +0300	[thread overview]
Message-ID: <CAP1tNvQOpnGwOUtHVTcxcMnv_GR=FNK3EuEFvBxDDcF-Fb9x3w@mail.gmail.com> (raw)
In-Reply-To: <20220421073546.GV4012@pengutronix.de>

чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <sha@pengutronix.de>:
>
> On Wed, Apr 20, 2022 at 12:53:22PM +0300, Alexander Shiyan wrote:
> > The MYD-AM335X Development Board designed by MYIR is a high-performance
> > ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core
> > controller board. It is based on up to 1GHz Texas Instruments (TI)
> > Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver
> > high DMIPs at a low cost while also delivering optional 3D graphics
> > acceleration and key peripherals.
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
...
> > +static struct omap_barebox_part myir_barebox_part = {
> > +     .nand_offset = SZ_128K,
> > +     .nand_size = SZ_512K,
> > +};
>
> Isn't this a bit too small? Putting a barebox into 128k seems very
> ambicous.

The boot image (MLO) should not exceed 128 KB in size,
so I think this should be enough.
In any case this size is already specified for the boot partition
in kernel DTS for this board. :)

...
> > +++ b/arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console
> > @@ -0,0 +1 @@
> > +console=ttyS0,115200n8 earlyprintk
>
> The console= part shouldn't be needed. barebox should add a console=
> parameter matching the current barebox console automatically.
>
> I wouldn't add the earlyprintk by default. It might break booting when
> the kernel is not exactly configured for your board. Anyway, that's
> personal taste.

OK.

...
> > diff --git a/arch/arm/configs/myirtech_am335x_myd_defconfig b/arch/arm/configs/myirtech_am335x_myd_defconfig
>
> Do you need this config? I rather prefer to add the board to some
> existing config, omap_defconfig in this case.

OK.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2022-04-21  7:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  9:53 Alexander Shiyan
2022-04-21  7:35 ` Sascha Hauer
2022-04-21  7:57   ` Alexander Shiyan [this message]
2022-04-21  8:30     ` Sascha Hauer
2022-04-21  8:58       ` Alexander Shiyan
2022-04-22  6:50         ` Sascha Hauer
2022-04-22  7:25           ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP1tNvQOpnGwOUtHVTcxcMnv_GR=FNK3EuEFvBxDDcF-Fb9x3w@mail.gmail.com' \
    --to=eagle.alexander923@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox