Re: [PATCH master 1/3] video: dw-hdmi: populate missing I2C adapter device node

[Alexander Shiyan <eagle.alexander923@gmail.com>]

ERROR: i2c11: of_i2c: invalid reg on /hdmi@fe0a0000/ports
dwhdmi-rockchip fe0a0000.hdmi@fe0a0000.of: registered I2C bus driver
dwhdmi-rockchip fe0a0000.hdmi@fe0a0000.of: Detected HDMI TX controller
v2.11a with HDCP (DWC HDMI 2.0 TX PHY)
rockchip-vop2 fe040000.vop@fe040000.of: Registered fb0 on VP0, window
Smart0-win0, type primary
rockchip-vop2 fe040000.vop@fe040000.of: Registered fb0_0 on VP0,
window Esmart1-win0, type overlay
NOTICE: rockchip-vop2 fe040000.vop@fe040000.of: no modes found on vp1
rockchip-vop2 fe040000.vop@fe040000.of: Registered fb1 on VP1, window
Smart1-win0, type primary
rockchip-vop2 fe040000.vop@fe040000.of: Registered fb1_0 on VP1,
window Esmart0-win0, type overlay
ERROR: i2c11: of_i2c: invalid reg on /hdmi@fe0a0000/ports

вс, 15 дек. 2024 г. в 12:54, Ahmad Fatoum <a.fatoum@pengutronix.de>:
>
> By recording the correct device tree node, it's possible to use OF
> aliases for deterministic numbering of the I2C adapter.
>
> Fixes: aea9e8bac578 ("video: add dw-hdmi driver")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/video/dw-hdmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/dw-hdmi.c b/drivers/video/dw-hdmi.c
> index 73201836b7e5..cd5de17e9bd7 100644
> --- a/drivers/video/dw-hdmi.c
> +++ b/drivers/video/dw-hdmi.c
> @@ -433,6 +433,7 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
>
>         adap = &i2c->adap;
>         adap->dev.parent = hdmi->dev;
> +       adap->dev.of_node = hdmi->dev->of_node;
>         adap->master_xfer = dw_hdmi_i2c_xfer;
>         adap->nr = -1;
>
> --
> 2.39.5
>
>