Re: [PATCH 2/3] x86: Add support for IDE on the legacy I/O ports

[Michel Stam <michel@reverze.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1296 bytes --]

Hello Alex,

Yes, I used send-email. I did notice that my editor changed some tabs to spaces, that is already fixed in my local repository. Ill send it after I tested whether everything still works.

Michel Stam


> On 5 apr. 2014, at 07:01, Alexander Aring <alex.aring@gmail.com> wrote:
> 
>> On Tue, Mar 25, 2014 at 12:12:00PM +0100, Michel Stam wrote:
>> ---
>> arch/x86/boards/x86_generic/generic_pc.c | 71 ++++++++++++++++++++++++
>> drivers/ata/ide-sff.c                    | 94
>> ++++++++++++++++++++++++++------
>> drivers/ata/intf_platform_ide.c          | 14 ++++-
>> include/ata_drive.h                      |  1 +
>> 4 files changed, 161 insertions(+), 19 deletions(-)
>> 
>> diff --git a/arch/x86/boards/x86_generic/generic_pc.c
>> b/arch/x86/boards/x86_generic/generic_pc.c
>> index 74a7224..6152afc 100644
>> --- a/arch/x86/boards/x86_generic/generic_pc.c
>> +++ b/arch/x86/boards/x86_generic/generic_pc.c
>> @@ -27,6 +27,10 @@
>> #include <ns16550.h>
>> #include <linux/err.h>
>> +#ifdef CONFIG_DISK_INTF_PLATFORM_IDE
> 
> Here is also a diff inconsitent... there is a space at beginning of the
> line?? Did you use git send-email? Check [0] for a introduction.
> 
> - Alex
> 
> [0] https://home.regit.org/technical-articles/git-for-the-newbie/

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 6165 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox