mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Sebastien Bourdelin" <sebastien.bourdelin@rtone.fr>
To: "Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Sebastien Bourdelin" <sebastien.bourdelin@gmail.com>,
	<barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: rpi: add CM4S device id
Date: Fri, 15 Dec 2023 09:32:42 +0100	[thread overview]
Message-ID: <CXORNZD4X32H.12QB7V42XZXNR@rtone.fr> (raw)
In-Reply-To: <5fc2e0c4-8bf7-4bab-8652-4a9d7aa98721@pengutronix.de>

On Thu Dec 14, 2023 at 6:17 PM CET, Ahmad Fatoum wrote:
> Hello Sebastien,
>
> On 14.12.23 17:35, Sebastien Bourdelin wrote:
> > Introduce the device id for the raspberry CM4S accordingly to [1].
> > 
> >  [1]: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#raspberry-pi-revision-codes
> > 
> > Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@rtone.fr>
>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> One comment below:
>
> > +	}, {
> > +		.hw_id = BCM2711_BOARD_REV_CM4_S,
> > +		.init = rpi_eth_init,
>
> Did you check that this is equally applicable on the RPI4?
> This ends up calling rpi_get_usbethaddr(), but that one
> calls GET_MAC_ADDRESS on the mbox interface, so I am not
> sure whether this is applicable to bcmgenet or not.
>
> Cheers,
> Ahmad
>

Hello Ahmad,

No i didn't check specifically for the CM4S, i assumed the CM4S is not
different then the CM4 and RPI4 on that part and kept the same logic
then:
https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/raspberry-pi/rpi-common.c#n646

I'm actually not sure how to validate that.

Cheers,
Sebastien.

> >  	}, {
> >  		.hw_id = U8_MAX
> >  	},
> > @@ -682,6 +685,7 @@ static const struct of_device_id rpi_of_match[] = {
> >  	/* BCM2711 based Boards */
> >  	{ .compatible = "raspberrypi,4-model-b", .data = rpi_4_ids },
> >  	{ .compatible = "raspberrypi,4-compute-module", .data = rpi_4_ids },
> > +	{ .compatible = "raspberrypi,4-compute-module-s", .data = rpi_4_ids },
> >  	{ .compatible = "raspberrypi,400", .data = rpi_4_ids },
> >  
> >  	{ /* sentinel */ },
> > diff --git a/include/mach/bcm283x/mbox.h b/include/mach/bcm283x/mbox.h
> > index 908ba17dba..cf5143673a 100644
> > --- a/include/mach/bcm283x/mbox.h
> > +++ b/include/mach/bcm283x/mbox.h
> > @@ -175,6 +175,7 @@ struct bcm2835_mbox_tag_hdr {
> >  #define BCM2837B0_BOARD_REV_ZERO_2	0x12
> >  #define BCM2711_BOARD_REV_400		0x13
> >  #define BCM2711_BOARD_REV_CM4		0x14
> > +#define BCM2711_BOARD_REV_CM4_S		0x15
> >  
> >  struct bcm2835_mbox_tag_get_board_rev {
> >  	struct bcm2835_mbox_tag_hdr tag_hdr;




  parent reply	other threads:[~2023-12-15  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 16:35 Sebastien Bourdelin
2023-12-14 17:17 ` Ahmad Fatoum
2023-12-15  8:27   ` Sebastien Bourdelin
2023-12-15  8:32   ` Sebastien Bourdelin [this message]
2023-12-18  6:53 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CXORNZD4X32H.12QB7V42XZXNR@rtone.fr \
    --to=sebastien.bourdelin@rtone.fr \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sebastien.bourdelin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox