Re: [PATCH v2 3/6] pinctrl: Add sun50i-a64 pinctrl driver

["Jules Maselbas" <jmaselbas@zdiv.net>]

On Tue Jan 14, 2025 at 9:39 AM CET, Ahmad Fatoum wrote:
> On 07.01.25 15:37, Jules Maselbas wrote:
>> sunxi pinctrl driver, adapted from Linux, is split in two parts:
>>  - pinctrl-sunxi.c that implements gpio, pinctrl and pinmux functions
>>  - pinctrl-sun50i-a64.c that declare sun50i pins and their functions.
>>    This file only require minor adaptations and be easily copied from Linux.
>> 
>> The pin functions are needed for uart, SD/MMC, and likely for other
>> controllers too.
>> 
>> Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>]
>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
>> ---
>> v1->v2:
>>  - removed `!IS_ENABLED(CONFIG_PINCTRL)` (Ahmad)
>
> Sascha suggested that of his own volition ;)
oopsy
>
>> +	func_name = sunxi_pinctrl_parse_function_prop(np);
>> +	if (!func_name) {
>> +		dev_err(dev, "%s: missing 'function' property\n", np->full_name);
>
> Nitpick: %pOF
Ack

>> +		return -EINVAL;
>> +	}
>
> Cheers,
> Ahmad