* "make distclean" doesn't remove generated MLO file
@ 2012-02-07 13:19 Robert P. J. Day
2012-02-07 16:34 ` Premi, Sanjeev
0 siblings, 1 reply; 9+ messages in thread
From: Robert P. J. Day @ 2012-02-07 13:19 UTC (permalink / raw)
To: U-Boot Version 2 (barebox)
i see that the latest barebox now automatically renames
barebox.bin.ift to MLO -- cool. but a subsequent "make distclean"
doesn't remove that generated MLO, which it should, no?
where would that removal properly belong? in "archmrproper"? it's
architecture specific, right?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 13:19 "make distclean" doesn't remove generated MLO file Robert P. J. Day
@ 2012-02-07 16:34 ` Premi, Sanjeev
2012-02-07 16:44 ` Robert P. J. Day
0 siblings, 1 reply; 9+ messages in thread
From: Premi, Sanjeev @ 2012-02-07 16:34 UTC (permalink / raw)
To: Robert P. J. Day, U-Boot Version 2 (barebox)
> -----Original Message-----
> From: barebox-bounces@lists.infradead.org
> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
> Robert P. J. Day
> Sent: Tuesday, February 07, 2012 6:49 PM
> To: U-Boot Version 2 (barebox)
> Subject: "make distclean" doesn't remove generated MLO file
>
>
> i see that the latest barebox now automatically renames
> barebox.bin.ift to MLO -- cool. but a subsequent "make distclean"
> doesn't remove that generated MLO, which it should, no?
>
> where would that removal properly belong? in "archmrproper"? it's
> architecture specific, right?
>
[snip]
This patch should help.
If you confirm, I can submit it formally.
~sanjeev
From 072ef5dd7022877fc1470b6dc14a0ec309eb68a0 Mon Sep 17 00:00:00 2001
From: Sanjeev Premi <premi@ti.com>
Date: Tue, 7 Feb 2012 21:58:50 +0530
Subject: [PATCH] omap: Remove MLO with distclean
Signed-off-by: Sanjeev Premi <premi@ti.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 5cf49da..5a03b32 100644
--- a/Makefile
+++ b/Makefile
@@ -1008,7 +1008,7 @@ MRPROPER_DIRS += include/config include2 usr/include
MRPROPER_FILES += .config .config.old include/asm .version .old_version \
include/generated/autoconf.h include/generated/version.h \
include/generated/utsrelease.h include/config.h \
- Module.symvers tags TAGS cscope*
+ Module.symvers tags TAGS cscope* MLO
# clean - Delete most, but leave enough to build external modules
#
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 16:34 ` Premi, Sanjeev
@ 2012-02-07 16:44 ` Robert P. J. Day
2012-02-07 16:59 ` Premi, Sanjeev
0 siblings, 1 reply; 9+ messages in thread
From: Robert P. J. Day @ 2012-02-07 16:44 UTC (permalink / raw)
To: Premi, Sanjeev; +Cc: U-Boot Version 2 (barebox)
On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> This patch should help.
> If you confirm, I can submit it formally.
>
> ~sanjeev
>
> >From 072ef5dd7022877fc1470b6dc14a0ec309eb68a0 Mon Sep 17 00:00:00 2001
> From: Sanjeev Premi <premi@ti.com>
> Date: Tue, 7 Feb 2012 21:58:50 +0530
> Subject: [PATCH] omap: Remove MLO with distclean
>
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 5cf49da..5a03b32 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1008,7 +1008,7 @@ MRPROPER_DIRS += include/config include2 usr/include
> MRPROPER_FILES += .config .config.old include/asm .version .old_version \
> include/generated/autoconf.h include/generated/version.h \
> include/generated/utsrelease.h include/config.h \
> - Module.symvers tags TAGS cscope*
> + Module.symvers tags TAGS cscope* MLO
>
> # clean - Delete most, but leave enough to build external modules
> #
based on this from the Makefile:
===== snip =====
# Directories & files removed with 'make clean'
CLEAN_DIRS += $(MODVERDIR)
CLEAN_FILES += barebox System.map
include/generated/barebox_default_env.h \
.tmp_version .tmp_barebox* barebox.bin barebox.S \
.tmp_kallsyms* barebox_default_env barebox.ldr
Doxyfile.version
# Directories & files removed with 'make mrproper'
MRPROPER_DIRS += include/config include2 usr/include
MRPROPER_FILES += .config .config.old include/asm .version
.old_version \
include/generated/autoconf.h include/generated/version.h \
include/generated/utsrelease.h include/config.h \
Module.symvers tags TAGS cscope* MLO
===== snip =====
i would think that it should be added to CLEAN_FILES, given its
relation to barebox.bin, etc. but either way will certainly work.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 16:44 ` Robert P. J. Day
@ 2012-02-07 16:59 ` Premi, Sanjeev
2012-02-07 17:02 ` Robert P. J. Day
0 siblings, 1 reply; 9+ messages in thread
From: Premi, Sanjeev @ 2012-02-07 16:59 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> Sent: Tuesday, February 07, 2012 10:15 PM
> To: Premi, Sanjeev
> Cc: U-Boot Version 2 (barebox)
> Subject: RE: "make distclean" doesn't remove generated MLO file
>
> On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
>
> > This patch should help.
> > If you confirm, I can submit it formally.
> >
> > ~sanjeev
> >
> > >From 072ef5dd7022877fc1470b6dc14a0ec309eb68a0 Mon Sep 17
> 00:00:00 2001
> > From: Sanjeev Premi <premi@ti.com>
> > Date: Tue, 7 Feb 2012 21:58:50 +0530
> > Subject: [PATCH] omap: Remove MLO with distclean
> >
> >
> > Signed-off-by: Sanjeev Premi <premi@ti.com>
> > ---
> > Makefile | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 5cf49da..5a03b32 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1008,7 +1008,7 @@ MRPROPER_DIRS += include/config
> include2 usr/include
> > MRPROPER_FILES += .config .config.old include/asm .version
> .old_version \
> > include/generated/autoconf.h
> include/generated/version.h \
> > include/generated/utsrelease.h
> include/config.h \
> > - Module.symvers tags TAGS cscope*
> > + Module.symvers tags TAGS cscope* MLO
> >
> > # clean - Delete most, but leave enough to build external modules
> > #
>
> based on this from the Makefile:
>
> ===== snip =====
>
> # Directories & files removed with 'make clean'
> CLEAN_DIRS += $(MODVERDIR)
> CLEAN_FILES += barebox System.map
> include/generated/barebox_default_env.h \
> .tmp_version .tmp_barebox* barebox.bin barebox.S \
> .tmp_kallsyms* barebox_default_env barebox.ldr
> Doxyfile.version
>
> # Directories & files removed with 'make mrproper'
> MRPROPER_DIRS += include/config include2 usr/include
> MRPROPER_FILES += .config .config.old include/asm .version
> .old_version \
> include/generated/autoconf.h
> include/generated/version.h \
> include/generated/utsrelease.h
> include/config.h \
> Module.symvers tags TAGS cscope* MLO
>
> ===== snip =====
>
> i would think that it should be added to CLEAN_FILES, given its
> relation to barebox.bin, etc. but either way will certainly work.
>
I usually compile both stages together with a 'make clean' in
between, hence decided to preserve MLO. Makes it easy to copy
both MLO and barebox.bin at same time.
Otherwise, yes, MLO goes better with CLEAN_FILES.
~sanjeev
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 16:59 ` Premi, Sanjeev
@ 2012-02-07 17:02 ` Robert P. J. Day
2012-02-07 17:05 ` Premi, Sanjeev
2012-02-07 21:59 ` Sascha Hauer
0 siblings, 2 replies; 9+ messages in thread
From: Robert P. J. Day @ 2012-02-07 17:02 UTC (permalink / raw)
To: Premi, Sanjeev; +Cc: U-Boot Version 2 (barebox)
On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> I usually compile both stages together with a 'make clean' in
> between, hence decided to preserve MLO. Makes it easy to copy both
> MLO and barebox.bin at same time.
is there any sort of requirement about cleaning in between those two
steps? if there is, that's a potential "gotcha" that should be
clearly documented.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 17:02 ` Robert P. J. Day
@ 2012-02-07 17:05 ` Premi, Sanjeev
2012-02-07 17:07 ` Robert P. J. Day
2012-02-07 21:59 ` Sascha Hauer
1 sibling, 1 reply; 9+ messages in thread
From: Premi, Sanjeev @ 2012-02-07 17:05 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> Sent: Tuesday, February 07, 2012 10:33 PM
> To: Premi, Sanjeev
> Cc: U-Boot Version 2 (barebox)
> Subject: RE: "make distclean" doesn't remove generated MLO file
>
> On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
>
> > I usually compile both stages together with a 'make clean' in
> > between, hence decided to preserve MLO. Makes it easy to copy both
> > MLO and barebox.bin at same time.
>
> is there any sort of requirement about cleaning in between those two
> steps? if there is, that's a potential "gotcha" that should be
> clearly documented.
No "gotcha" that I know of - but just a habit!
~sanjeev
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 17:05 ` Premi, Sanjeev
@ 2012-02-07 17:07 ` Robert P. J. Day
2012-02-07 17:27 ` Premi, Sanjeev
0 siblings, 1 reply; 9+ messages in thread
From: Robert P. J. Day @ 2012-02-07 17:07 UTC (permalink / raw)
To: Premi, Sanjeev; +Cc: U-Boot Version 2 (barebox)
On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> > -----Original Message-----
> > From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> > Sent: Tuesday, February 07, 2012 10:33 PM
> > To: Premi, Sanjeev
> > Cc: U-Boot Version 2 (barebox)
> > Subject: RE: "make distclean" doesn't remove generated MLO file
> >
> > On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> >
> > > I usually compile both stages together with a 'make clean' in
> > > between, hence decided to preserve MLO. Makes it easy to copy both
> > > MLO and barebox.bin at same time.
> >
> > is there any sort of requirement about cleaning in between those two
> > steps? if there is, that's a potential "gotcha" that should be
> > clearly documented.
>
> No "gotcha" that I know of - but just a habit!
i figured as much. but under the circumstances, i think removing
MLO should be part of CLEAN_FILES given its obvious relationship to
things like barebox.bin. philosophically, it just makes more sense.
and on that note, i will now shut up about it.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: "make distclean" doesn't remove generated MLO file
2012-02-07 17:07 ` Robert P. J. Day
@ 2012-02-07 17:27 ` Premi, Sanjeev
0 siblings, 0 replies; 9+ messages in thread
From: Premi, Sanjeev @ 2012-02-07 17:27 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> Sent: Tuesday, February 07, 2012 10:38 PM
> To: Premi, Sanjeev
> Cc: U-Boot Version 2 (barebox)
> Subject: RE: "make distclean" doesn't remove generated MLO file
>
> On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
>
> > > -----Original Message-----
> > > From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> > > Sent: Tuesday, February 07, 2012 10:33 PM
> > > To: Premi, Sanjeev
> > > Cc: U-Boot Version 2 (barebox)
> > > Subject: RE: "make distclean" doesn't remove generated MLO file
> > >
> > > On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> > >
> > > > I usually compile both stages together with a 'make clean' in
> > > > between, hence decided to preserve MLO. Makes it easy
> to copy both
> > > > MLO and barebox.bin at same time.
> > >
> > > is there any sort of requirement about cleaning in
> between those two
> > > steps? if there is, that's a potential "gotcha" that should be
> > > clearly documented.
> >
> > No "gotcha" that I know of - but just a habit!
>
> i figured as much. but under the circumstances, i think removing
> MLO should be part of CLEAN_FILES given its obvious relationship to
> things like barebox.bin. philosophically, it just makes more sense.
> and on that note, i will now shut up about it.
I noted in earlier response:
> Otherwise, yes, MLO goes better with CLEAN_FILES.
So, you are right.
Let us wait if there is any other opinion on this.
~sanjeev
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: "make distclean" doesn't remove generated MLO file
2012-02-07 17:02 ` Robert P. J. Day
2012-02-07 17:05 ` Premi, Sanjeev
@ 2012-02-07 21:59 ` Sascha Hauer
1 sibling, 0 replies; 9+ messages in thread
From: Sascha Hauer @ 2012-02-07 21:59 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
On Tue, Feb 07, 2012 at 12:02:56PM -0500, Robert P. J. Day wrote:
> On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
>
> > I usually compile both stages together with a 'make clean' in
> > between, hence decided to preserve MLO. Makes it easy to copy both
> > MLO and barebox.bin at same time.
>
> is there any sort of requirement about cleaning in between those two
> steps? if there is, that's a potential "gotcha" that should be
> clearly documented.
I'm not aware of any issues here. I only do a make clean when changing
the architecture.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-02-07 21:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-07 13:19 "make distclean" doesn't remove generated MLO file Robert P. J. Day
2012-02-07 16:34 ` Premi, Sanjeev
2012-02-07 16:44 ` Robert P. J. Day
2012-02-07 16:59 ` Premi, Sanjeev
2012-02-07 17:02 ` Robert P. J. Day
2012-02-07 17:05 ` Premi, Sanjeev
2012-02-07 17:07 ` Robert P. J. Day
2012-02-07 17:27 ` Premi, Sanjeev
2012-02-07 21:59 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox