From: andreas.willig@rafi.de
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: Clocks on Barebox
Date: Wed, 10 Jun 2015 07:10:25 +0200 [thread overview]
Message-ID: <OF768B6D2F.3B4803F6-ONC1257E60.001C6BB6-C1257E60.001C6BBF@o0802.rafi.inhouse> (raw)
In-Reply-To: <20150610045944.GU6325@pengutronix.de>
Hi Sascha,
you make my day :) this is it, everything is fine, i removed my Workaround with hardinit osc to tree, and everything works smooth and beautiful :)
Problem solved, looking Forward, seeing this patch on branch next :)
Mit freundlichen Grüßen aus Berg/ With kind regards
i.A. Andreas Willig
Dipl.-Ing. (FH)
Entwicklung Elektronik
RAFI GmbH & Co. KG
Postfach 2060
88276 Ravensburg
Tel.: +49 (0) 751 89-6142
mailto:andreas.willig@rafi.de, http://www.rafi.de
Kommanditgesellschaft: Sitz Berg, Amtsgericht Ulm, HRA 550059
Komplementär: RAFI Beteiligungs-GmbH, Sitz Berg, Amtsgericht Ulm HRB 550074
Geschäftsführer: Albert Wasmeier, Dipl.-Kfm. Gerhard Schenk
USt-Ident.-Nr.: DE 146 392 319, Steuer-Nr.: 77079/00291
-----Sascha Hauer <s.hauer@pengutronix.de> schrieb: -----
An: andreas.willig@rafi.de
Von: Sascha Hauer <s.hauer@pengutronix.de>
Datum: 10.06.2015 06:59
Kopie: barebox@lists.infradead.org
Betreff: Re: Clocks on Barebox
On Tue, Jun 09, 2015 at 01:28:17PM +0200, andreas.willig@rafi.de wrote:
> Hi Sascha,
>
> here my oftables section from barebox.map:
>
> .oftables 0x278f7bc0 0x18
> 0x278f7bc0 . = ALIGN (0x8)
> 0x278f7bc0 __clk_of_table_start = .
> *(.__clk_of_table_*)
> .__clk_of_table_end
> 0x278f7bc0 0x8 drivers/built-in.o
> 0x278f7bc0 __clk_of_table_sentinel
> .__clk_of_table_fixed_clk
> 0x278f7bc8 0x8 drivers/built-in.o
> 0x278f7bc8 __clk_of_table_fixed_clk
> .__clk_of_table_fixed_factor_clk
> 0x278f7bd0 0x8 drivers/built-in.o
> 0x278f7bd0 __clk_of_table_fixed_factor_clk
> 0x278f7bd8 __clk_of_table_end = .
And here's the problem. The sentinel entry containing only NULL marks
the end of the array. It should be the last entry, but here it's the
first entry which effectively makes the table empty. It turned out it
was pure luck that the sentinel entry ended up as last entry normally.
I've just sent out a patch fixing this, please test.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-06-10 5:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 8:12 andreas.willig
2015-06-01 11:41 ` Sascha Hauer
2015-06-02 3:42 ` andreas.willig
2015-06-03 8:19 ` Sascha Hauer
2015-06-09 5:21 ` andreas.willig
2015-06-09 10:18 ` Sascha Hauer
2015-06-09 11:28 ` andreas.willig
2015-06-10 4:59 ` Sascha Hauer
2015-06-10 5:10 ` andreas.willig [this message]
2015-06-11 5:48 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF768B6D2F.3B4803F6-ONC1257E60.001C6BB6-C1257E60.001C6BBF@o0802.rafi.inhouse \
--to=andreas.willig@rafi.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox