RE: [PATCH v2 4/4] ARM: ls1021a: initial Ethernet and mdio configuration

[Renaud Barbier <Renaud.Barbier@ametek.com>]

> > +&enet0 {
> > +     status = "disabled";
> > +};
> > +
> > +&enet1 {
> > +     tbi-handle = <&tbi1>;
> > +     phy-handle = <&phy3>;
> > +     phy-mode = "sgmii";
> > +     /* Disable property as transmit fails without a DMA sync */
> > +     /delete-property/ dma-coherent;
> > +};
> > +
> > +&enet2 {
> > +     status = "disabled";
> > +};
> > +
> > +&mdio0 {
> > +     /* Rename the compatible name property as the mdio register offset
> > +      * in the gianfar driver depends on this name. Once the driver
> > +      * is in sync with Linux, it may be gone.
> > +      */
> > +     compatible = "fsl,etsec2-mdio";
> 
> What am I missing here? The "fsl,etsec2-mdio" compatible is introduced in
> your patch series and the original "gianfar" compatible is unused in barebox,
> so why not use the original "gianfar" compatible?

This looks like a brain meltdown. Working on it.

> 
> Sascha
> 
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       |
> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!EYn
> wk0KOC4uaZ6o2g405vX9jY5cYxTXggB3OWKRK4fkhKYQkD1ipDYAvpoXwCD1xI
> ouD69egxnltsNg0UUl0r8QgLw$   |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |