mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jookia <contact@jookia.org>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] I2C: i.MX: early: Use internal udelay
Date: Thu, 2 Feb 2023 05:12:58 +1100	[thread overview]
Message-ID: <Y9qrqiyisq6gjMQx@novena-choice-citizen> (raw)
In-Reply-To: <CAP1tNvRo98Xoo2z3GmacoYZ-vR6FTnKcJYxrop3HJZi-QnFt6Q@mail.gmail.com>

On Wed, Feb 01, 2023 at 08:50:50PM +0300, Alexander Shiyan wrote:
> Hello!
> 
> Just a nitpick, udelay means milliseconds (udelay_(us)),
> which isn't quite right in this case,
> so I think we should use the "loops" value here (delay_loops() or so)).
> 
> Thanks!

Hi Alexander,

Thanks for the review!

Are you sure? us means microseconds from what I understand.
I've also posted an updated version of this patch just last night.

John.



  reply	other threads:[~2023-02-01 18:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 18:56 John Watts
2023-01-30 10:27 ` Sascha Hauer
2023-01-30 10:42   ` John Watts
2023-01-30 12:17     ` Sascha Hauer
2023-01-30 12:24       ` John Watts
2023-01-30 12:31         ` Sascha Hauer
2023-01-30 12:56           ` John Watts
2023-01-30 16:36             ` Sascha Hauer
2023-01-30 18:42               ` John Watts
2023-01-31  6:14                 ` Sascha Hauer
2023-01-31  6:33                   ` John Watts
2023-02-02 14:21   ` Jules Maselbas
2023-02-02 14:27     ` Ahmad Fatoum
2023-02-01 17:50 ` Alexander Shiyan
2023-02-01 18:12   ` Jookia [this message]
2023-02-01 19:44   ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9qrqiyisq6gjMQx@novena-choice-citizen \
    --to=contact@jookia.org \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox