[PATCH] fixup! complete: give device_param_complete a flags parameter

[PATCH] fixup! complete: give device_param_complete a flags parameter

[Ahmad Fatoum]

When completing an existing variable, we want a trailing assignment, so
the use can just start typing the value.

This was the behavior before the commit being fixed up broke it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/complete.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/complete.c b/common/complete.c
index 6cb674a0cc9c..5327944ca93b 100644
--- a/common/complete.c
+++ b/common/complete.c
@@ -469,7 +469,7 @@ int complete(char *instr, char **outstr)
 		} else {
 			command_complete(&sl, instr);
 			path_command_complete(&sl, instr);
-			env_param_complete(&sl, instr, 0);
+			env_param_complete(&sl, instr, DEVPARAM_COMPLETE_ASSIGNMENT);
 		}
 		if (*instr == '$')
 			env_param_complete(&sl, instr + 1, DEVPARAM_COMPLETE_DOLLAR);
-- 
2.39.5

Re: [PATCH] fixup! complete: give device_param_complete a flags parameter

[Sascha Hauer]

On Thu, Mar 27, 2025 at 08:48:14AM +0100, Ahmad Fatoum wrote:
> When completing an existing variable, we want a trailing assignment, so
> the use can just start typing the value.
> 
> This was the behavior before the commit being fixed up broke it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  common/complete.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/common/complete.c b/common/complete.c
> index 6cb674a0cc9c..5327944ca93b 100644
> --- a/common/complete.c
> +++ b/common/complete.c
> @@ -469,7 +469,7 @@ int complete(char *instr, char **outstr)
>  		} else {
>  			command_complete(&sl, instr);
>  			path_command_complete(&sl, instr);
> -			env_param_complete(&sl, instr, 0);
> +			env_param_complete(&sl, instr, DEVPARAM_COMPLETE_ASSIGNMENT);
>  		}
>  		if (*instr == '$')
>  			env_param_complete(&sl, instr + 1, DEVPARAM_COMPLETE_DOLLAR);
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |