mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
@ 2024-11-18 16:43 Sven Püschel
  2024-11-18 17:56 ` Ahmad Fatoum
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Sven Püschel @ 2024-11-18 16:43 UTC (permalink / raw)
  To: barebox; +Cc: Sven Püschel

Skip sd/sdio detection on the eMMC to reduce the detection time by
about 270ms. This change is already part of the kernel dtsi file
(see  dts/src/arm64/freescale/imx8mp-skov-reva.dtsi).

Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
---
 arch/arm/dts/imx8mp-skov.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/dts/imx8mp-skov.dts b/arch/arm/dts/imx8mp-skov.dts
index 0c0ada1a5c..5271c9deab 100644
--- a/arch/arm/dts/imx8mp-skov.dts
+++ b/arch/arm/dts/imx8mp-skov.dts
@@ -425,6 +425,8 @@ &usdhc3 {
 	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
 	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
 	bus-width = <8>;
+	no-sd;
+	no-sdio;
 	non-removable;
 	status = "okay";
 };
-- 
2.47.0




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
  2024-11-18 16:43 [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC Sven Püschel
@ 2024-11-18 17:56 ` Ahmad Fatoum
  2024-11-25  8:52 ` Sascha Hauer
  2024-11-25  8:54 ` Sascha Hauer
  2 siblings, 0 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2024-11-18 17:56 UTC (permalink / raw)
  To: Sven Püschel, barebox

On 18.11.24 17:43, Sven Püschel wrote:
> Skip sd/sdio detection on the eMMC to reduce the detection time by
> about 270ms. This change is already part of the kernel dtsi file
> (see  dts/src/arm64/freescale/imx8mp-skov-reva.dtsi).
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Next up HS200? ;-)

Cheers,
Ahmad

> ---
>  arch/arm/dts/imx8mp-skov.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mp-skov.dts b/arch/arm/dts/imx8mp-skov.dts
> index 0c0ada1a5c..5271c9deab 100644
> --- a/arch/arm/dts/imx8mp-skov.dts
> +++ b/arch/arm/dts/imx8mp-skov.dts
> @@ -425,6 +425,8 @@ &usdhc3 {
>  	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
>  	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
>  	bus-width = <8>;
> +	no-sd;
> +	no-sdio;
>  	non-removable;
>  	status = "okay";
>  };


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
  2024-11-18 16:43 [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC Sven Püschel
  2024-11-18 17:56 ` Ahmad Fatoum
@ 2024-11-25  8:52 ` Sascha Hauer
  2024-11-25  8:54 ` Sascha Hauer
  2 siblings, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2024-11-25  8:52 UTC (permalink / raw)
  To: barebox, Sven Püschel


On Mon, 18 Nov 2024 17:43:44 +0100, Sven Püschel wrote:
> Skip sd/sdio detection on the eMMC to reduce the detection time by
> about 270ms. This change is already part of the kernel dtsi file
> (see  dts/src/arm64/freescale/imx8mp-skov-reva.dtsi).
> 
> 

Applied, thanks!

[1/1] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
      https://git.pengutronix.de/cgit/barebox/commit/?id=099b63932c4a (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
  2024-11-18 16:43 [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC Sven Püschel
  2024-11-18 17:56 ` Ahmad Fatoum
  2024-11-25  8:52 ` Sascha Hauer
@ 2024-11-25  8:54 ` Sascha Hauer
  2024-11-25  9:02   ` Oleksij Rempel
  2 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2024-11-25  8:54 UTC (permalink / raw)
  To: Sven Püschel; +Cc: barebox, Oleksij Rempel, Ulrich Oelmann

On Mon, Nov 18, 2024 at 05:43:44PM +0100, Sven Püschel wrote:
> Skip sd/sdio detection on the eMMC to reduce the detection time by
> about 270ms. This change is already part of the kernel dtsi file
> (see  dts/src/arm64/freescale/imx8mp-skov-reva.dtsi).

Oleksij, Ulrich,

Wouldn't it make sense to use the upstream dts?

Sascha

> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> ---
>  arch/arm/dts/imx8mp-skov.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mp-skov.dts b/arch/arm/dts/imx8mp-skov.dts
> index 0c0ada1a5c..5271c9deab 100644
> --- a/arch/arm/dts/imx8mp-skov.dts
> +++ b/arch/arm/dts/imx8mp-skov.dts
> @@ -425,6 +425,8 @@ &usdhc3 {
>  	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
>  	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
>  	bus-width = <8>;
> +	no-sd;
> +	no-sdio;
>  	non-removable;
>  	status = "okay";
>  };
> -- 
> 2.47.0
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC
  2024-11-25  8:54 ` Sascha Hauer
@ 2024-11-25  9:02   ` Oleksij Rempel
  0 siblings, 0 replies; 5+ messages in thread
From: Oleksij Rempel @ 2024-11-25  9:02 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Sven Püschel, barebox, Ulrich Oelmann

On Mon, Nov 25, 2024 at 09:54:38AM +0100, Sascha Hauer wrote:
> On Mon, Nov 18, 2024 at 05:43:44PM +0100, Sven Püschel wrote:
> > Skip sd/sdio detection on the eMMC to reduce the detection time by
> > about 270ms. This change is already part of the kernel dtsi file
> > (see  dts/src/arm64/freescale/imx8mp-skov-reva.dtsi).
> 
> Oleksij, Ulrich,
> 
> Wouldn't it make sense to use the upstream dts?

always :)

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-11-25  9:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-18 16:43 [PATCH] ARM: dts: i.MX8MP: imx8mp-skov: skip sd/sdio detection on the eMMC Sven Püschel
2024-11-18 17:56 ` Ahmad Fatoum
2024-11-25  8:52 ` Sascha Hauer
2024-11-25  8:54 ` Sascha Hauer
2024-11-25  9:02   ` Oleksij Rempel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox