Re: [PATCH] commands: add config option for dfu command

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Jan 09, 2025 at 10:10:42AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 09.01.25 08:44, Sascha Hauer wrote:
> > Add an extra config option for the dfu command to avoid building it in
> > non interactive builds which leads to linker errors.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  commands/Kconfig  | 6 ++++++
> >  commands/Makefile | 2 +-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/commands/Kconfig b/commands/Kconfig
> > index 67116ec9fc..a30299abf6 100644
> > --- a/commands/Kconfig
> > +++ b/commands/Kconfig
> > @@ -2172,6 +2172,12 @@ config CMD_USBGADGET
> >  	depends on USB_GADGET
> >  	prompt "usbgadget"
> >  
> > +config CMD_DFU
> > +	bool
> > +	depends on USB_GADGET_DFU
> > +	default y
> 
> Let's use the occasion and make it not enabled by default?
> 
> > +	prompt "dfu"
> 
> Please add a help text pointing out usbgdaget and mentioning that
> the downside of using dfu (blocks shell).

Did that while applying.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |