[PATCH] commands: add config option for dfu command

[PATCH] commands: add config option for dfu command

[Sascha Hauer]

Add an extra config option for the dfu command to avoid building it in
non interactive builds which leads to linker errors.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 commands/Kconfig  | 6 ++++++
 commands/Makefile | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/commands/Kconfig b/commands/Kconfig
index 67116ec9fc..a30299abf6 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -2172,6 +2172,12 @@ config CMD_USBGADGET
 	depends on USB_GADGET
 	prompt "usbgadget"
 
+config CMD_DFU
+	bool
+	depends on USB_GADGET_DFU
+	default y
+	prompt "dfu"
+
 config CMD_WD
 	bool
 	depends on WATCHDOG
diff --git a/commands/Makefile b/commands/Makefile
index a98c39637c..0dfa0a33a4 100644
--- a/commands/Makefile
+++ b/commands/Makefile
@@ -64,7 +64,7 @@ obj-$(CONFIG_CMD_INSMOD)	+= insmod.o
 obj-$(CONFIG_CMD_SPLASH)	+= splash.o
 obj-$(CONFIG_CMD_FBTEST)	+= fbtest.o
 obj-$(CONFIG_CMD_BEEP)		+= beep.o
-obj-$(CONFIG_USB_GADGET_DFU)	+= dfu.o
+obj-$(CONFIG_CMD_DFU)		+= dfu.o
 obj-$(CONFIG_USB_GADGET_SERIAL)	+= usbserial.o
 obj-$(CONFIG_CMD_GPIO)		+= gpio.o
 obj-$(CONFIG_CMD_UNCOMPRESS)	+= uncompress.o
-- 
2.39.5

Re: [PATCH] commands: add config option for dfu command

[Ahmad Fatoum]

Hello Sascha,

On 09.01.25 08:44, Sascha Hauer wrote:
> Add an extra config option for the dfu command to avoid building it in
> non interactive builds which leads to linker errors.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  commands/Kconfig  | 6 ++++++
>  commands/Makefile | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 67116ec9fc..a30299abf6 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -2172,6 +2172,12 @@ config CMD_USBGADGET
>  	depends on USB_GADGET
>  	prompt "usbgadget"
>  
> +config CMD_DFU
> +	bool
> +	depends on USB_GADGET_DFU
> +	default y

Let's use the occasion and make it not enabled by default?

> +	prompt "dfu"

Please add a help text pointing out usbgdaget and mentioning that
the downside of using dfu (blocks shell).

Thanks,
Ahmad

> +
>  config CMD_WD
>  	bool
>  	depends on WATCHDOG
> diff --git a/commands/Makefile b/commands/Makefile
> index a98c39637c..0dfa0a33a4 100644
> --- a/commands/Makefile
> +++ b/commands/Makefile
> @@ -64,7 +64,7 @@ obj-$(CONFIG_CMD_INSMOD)	+= insmod.o
>  obj-$(CONFIG_CMD_SPLASH)	+= splash.o
>  obj-$(CONFIG_CMD_FBTEST)	+= fbtest.o
>  obj-$(CONFIG_CMD_BEEP)		+= beep.o
> -obj-$(CONFIG_USB_GADGET_DFU)	+= dfu.o
> +obj-$(CONFIG_CMD_DFU)		+= dfu.o
>  obj-$(CONFIG_USB_GADGET_SERIAL)	+= usbserial.o
>  obj-$(CONFIG_CMD_GPIO)		+= gpio.o
>  obj-$(CONFIG_CMD_UNCOMPRESS)	+= uncompress.o


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] commands: add config option for dfu command

[Sascha Hauer]

On Thu, Jan 09, 2025 at 10:10:42AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 09.01.25 08:44, Sascha Hauer wrote:
> > Add an extra config option for the dfu command to avoid building it in
> > non interactive builds which leads to linker errors.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  commands/Kconfig  | 6 ++++++
> >  commands/Makefile | 2 +-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/commands/Kconfig b/commands/Kconfig
> > index 67116ec9fc..a30299abf6 100644
> > --- a/commands/Kconfig
> > +++ b/commands/Kconfig
> > @@ -2172,6 +2172,12 @@ config CMD_USBGADGET
> >  	depends on USB_GADGET
> >  	prompt "usbgadget"
> >  
> > +config CMD_DFU
> > +	bool
> > +	depends on USB_GADGET_DFU
> > +	default y
> 
> Let's use the occasion and make it not enabled by default?
> 
> > +	prompt "dfu"
> 
> Please add a help text pointing out usbgdaget and mentioning that
> the downside of using dfu (blocks shell).

Did that while applying.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] commands: add config option for dfu command

[Sascha Hauer]

On Thu, 09 Jan 2025 08:44:33 +0100, Sascha Hauer wrote:
> Add an extra config option for the dfu command to avoid building it in
> non interactive builds which leads to linker errors.
> 
> 

Applied, thanks!

[1/1] commands: add config option for dfu command
      https://git.pengutronix.de/cgit/barebox/commit/?id=c23c6b20899c (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>