Re: [PATCH v2 5/6] ARM: sunxi: Introduce mach-sunxi

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Jules,

On Tue, Jan 07, 2025 at 03:37:39PM +0100, Jules Maselbas wrote:
> Add some boilerplate, Makefiles, Kbuild.
> A generic barebox-dt-2nd.img image can be build for A64 SoC using
> the sunxi_v8_defconfig.
> 
> This image can be booted from u-boot and has been tested on Pine64+,
> it should work on other A64 SoC such as the pinephone, and other Pine64
> boards, it might also work on H6 SoC which uses the same sd/mmc controler.
> 
> Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
> ---
> v1->v2:
>  - removed RELOCATABLE and HAVE_PBL_MULTI_IMAGES from Kconfig (Ahmad)
>  - used __dummy__.o insead of an empty file (Ahmad)
>  - removed include/mach/sunxi/barebox-arm.h (Ahmad)
> 
>  arch/arm/Kconfig                    | 12 ++++++++++++
>  arch/arm/Makefile                   |  1 +
>  arch/arm/configs/sunxi_v8_defconfig | 12 ++++++++++++
>  arch/arm/mach-sunxi/Kconfig         | 12 ++++++++++++
>  arch/arm/mach-sunxi/Makefile        |  1 +
>  5 files changed, 38 insertions(+)
>  create mode 100644 arch/arm/configs/sunxi_v8_defconfig
>  create mode 100644 arch/arm/mach-sunxi/Kconfig
>  create mode 100644 arch/arm/mach-sunxi/Makefile
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 0251f2dcef..83adfaddf7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -109,6 +109,17 @@ config ARCH_SOCFPGA
>  	select CPU_V7
>  	select COMMON_CLK
>  
> +config ARCH_SUNXI
> +	bool "Allwinner SoCs"
> +	depends on 64BIT
> +	select CLKDEV_LOOKUP
> +	select COMMON_CLK
> +	select COMMON_CLK_OF_PROVIDER
> +	select GPIOLIB
> +	select OFDEVICE
> +	select OFTREE
> +	select PINCTRL

Can you put this into the multiarch section, i.e. outside the "ARM
system type" choice?

That way we can compile sunxi along with other SoCs.

> diff --git a/arch/arm/configs/sunxi_v8_defconfig b/arch/arm/configs/sunxi_v8_defconfig

With this separate config shouldn't be necessary anymore. Just enable
the sunxi specific drivers in multi_v8_defconfig.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |