From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 Jan 2025 11:02:04 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYMhP-000YJB-1A for lore@lore.pengutronix.de; Thu, 16 Jan 2025 11:02:04 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tYMhP-0001Dv-FM for lore@pengutronix.de; Thu, 16 Jan 2025 11:02:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k5Jvw1047hveFht2hkx/rmrx9QF15o7YWhUsKKNZUqk=; b=z8hbjav2YSZ1q1kJpQMMSNa0E7 +x6LA9nGt0YOFnREW3Oz5HgZxZbs9gmjkiKDZp5Ka+ONYzIFT7vcjjGGXpD0tELtPBm9VrRn/OCxn b1nPGmZ0krI3r02pdF3N9Dx8v7AWyNrGn3WUJis1uqaD9bCkyb4KJfFGCumGzMu2DFSBCX78J0xX+ cIz/qT5h1fHox1BtFAJ60Ee4qhFOUepXhtC+Paxf5s2PLVeltRKo4huofJSDqhMgrzmlSG/LiVgn1 86iNNwDxNBlSlG/qZHppSN9fDpxMduPo6z0QPfJHk3FC/5GKxJZKJChcklceB5g9IG1FTX8oErmPf VRsLJZAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYMgs-0000000ERDN-23VF; Thu, 16 Jan 2025 10:01:30 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYMgp-0000000ERCy-0ZPR for barebox@lists.infradead.org; Thu, 16 Jan 2025 10:01:28 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tYMgm-00018l-Dz; Thu, 16 Jan 2025 11:01:24 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYMgm-000EMV-0m; Thu, 16 Jan 2025 11:01:24 +0100 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tYMgm-00DhuM-0V; Thu, 16 Jan 2025 11:01:24 +0100 Date: Thu, 16 Jan 2025 11:01:24 +0100 From: Sascha Hauer To: Bastian Krause Cc: barebox@lists.infradead.org, Rouven Czerwinski , Marco Felsch , Stefan Kerkmann Message-ID: References: <20250106113340.1224335-1-bst@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_020127_172677_1566CF9F X-CRM114-Status: GOOD ( 21.43 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] scripts: imx: pass semicolons as substitute chars to compiler macros for CSF templating X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Fri, Jan 10, 2025 at 05:18:51PM +0100, Bastian Krause wrote: > Hi Sascha, > > On 1/10/25 12:31 PM, Sascha Hauer wrote: > > On Mon, Jan 06, 2025 at 12:33:40PM +0100, Bastian Krause wrote: > > > With CONFIG_HAB_CERTS_ENV=y, paths and PKCS#11 URIs to the HAB > > > certificates are taken from environment variables (allowing for better > > > integration with build systems). In this case these values are passed > > > internally via compiler macros (-D) to the imx-image host tool. PKCS#11 > > > URIs usually contain semicolons. Semicolons, however, cannot be passed > > > via compiler macros and cannot be escaped. > > > > Try harder. > > > > gcc -DFOO='"bar;baz"' test.c > > > > #include > > > > int main(void) > > { > > printf(FOO); > > } > > > > Works as expected, so does it work when you add single quotes around the > > URI? > > This actually works: > > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -570,8 +570,8 @@ imxcfg_cpp_flags = -Wp,-MD,$(depfile) -nostdinc -x > assembler-with-cpp \ > $(call overwrite-hab-env,CONFIG_HABV3_CSF_CRT_DER) \ > $(call overwrite-hab-env,CONFIG_HABV3_IMG_CRT_DER) \ > $(call overwrite-hab-env,CONFIG_HABV4_TABLE_BIN) \ > - $(call overwrite-hab-env,CONFIG_HABV4_CSF_CRT_PEM) \ > - $(call overwrite-hab-env,CONFIG_HABV4_IMG_CRT_PEM) \ > + -DCONFIG_HABV4_CSF_CRT_PEM='"$(CONFIG_HABV4_CSF_CRT_PEM)"' \ > + -DCONFIG_HABV4_IMG_CRT_PEM='"$(CONFIG_HABV4_IMG_CRT_PEM)"' \ > $(call overwrite-fit-env,CONFIG_BOOTM_FITIMAGE_PUBKEY) \ > > dcd-tmp = $(subst $(comma),_,$(dot-target).dcd.tmp) > > > But I had no luck integrating the single quote approach in overwrite- > hab-env. Maybe my quoting/escaping fu is not strong enough. Could you > take a look? Took some time, but it should work now. See the patch I just sent. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |