From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 28 Feb 2024 13:28:18 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rfJ2o-00DPen-02 for lore@lore.pengutronix.de; Wed, 28 Feb 2024 13:28:18 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfJ2n-0007bA-6r for lore@pengutronix.de; Wed, 28 Feb 2024 13:28:17 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NAWyDPn+XWSPJ9Y08xfTHwjTwg/B0goFpm+CneoPnFk=; b=uB5UBdYKey/GN+5rlm1jfT7ipg WnQ4mOt4MoGC2eVveSL2mffeHbjFLaLz9zc4WR2DmCTaJnHiJshsfQO/xXhZ51XIboaR4WXTwOX4Q 8pedDt8en0XJ0UAO0PKh1qFk8RwSYygEM00g6hGN++QvSSmieW4fyv+4AkoR0JiOUV20uvXNYnfVB 2phOgoxMRwPhGJ5c/nxPkSa0Mny1z3uqo7KMeEQ74CdxAU9zP0r/c7SrXc/nkHiLB0OSj60W19Bmf DZGePEkl/fTBiNoFWwJYzunN4iuNFSDTp7KssgEpYTlH0YrpBFeQdTy2hzlFdZ1Jl6zczl9xvtcNj eZ5qPwpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfJ2A-00000009ElN-41Iz; Wed, 28 Feb 2024 12:27:38 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfJ26-00000009Eis-1HXJ for barebox@lists.infradead.org; Wed, 28 Feb 2024 12:27:36 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfJ22-0007P0-He; Wed, 28 Feb 2024 13:27:30 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfJ21-003OEl-Uj; Wed, 28 Feb 2024 13:27:29 +0100 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rfJ21-00C5Dh-2l; Wed, 28 Feb 2024 13:27:29 +0100 Date: Wed, 28 Feb 2024 13:27:29 +0100 From: Sascha Hauer To: Antony Pavlov Message-ID: References: <20240205125900.c4b182f57b6efe0152beee24@gmail.com> <90de314f-b7a7-4b49-8c72-ec45aa3d38e2@pengutronix.de> <20240228102615.938c123aaae9137aae26439c@gmail.com> <20240228145058.1df54e06780cdb4060fce1d7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228145058.1df54e06780cdb4060fce1d7@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_042734_369285_D4C418B8 X-CRM114-Status: GOOD ( 42.01 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ahmad Fatoum , Dan Shelton , barebox@lists.infradead.org Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: NFSv4 boot support? X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Wed, Feb 28, 2024 at 02:50:58PM +0300, Antony Pavlov wrote: > On Wed, 28 Feb 2024 10:20:27 +0100 > Sascha Hauer wrote: > > > Hi Sascha! > > > On Wed, Feb 28, 2024 at 10:26:15AM +0300, Antony Pavlov wrote: > > > On Sat, 17 Feb 2024 09:51:02 +0100 > > > Ahmad Fatoum wrote: > > > > > > Hi All! > > > > > > > Hello Antony, > > > > > > > > On 05.02.24 10:59, Antony Pavlov wrote: > > > > > On Wed, 31 Jan 2024 22:37:50 +0100 > > > > > Ahmad Fatoum wrote: > > > > > > > > > > Hi All! > > > > > > > > > >> Hello Dan, > > > > >> > > > > >> On 31.01.24 22:03, Dan Shelton wrote: > > > > >>> Hello! > > > > >>> > > > > >>> Does barebox support booting from a NFSv4 filesystem, e.g. boot from > > > > >>> NFSv4 filesystem into a Linux NFSv4 netroot (diskless machine)? > > > > >> > > > > >> The barebox network stack only does UDP/IP. There have been attempts to > > > > >> bring a TCP stack into barebox, but none have so far succeeded to > > > > >> make it mainline. This is a hard requirement before we can consider > > > > >> supporting NFSv4. I hope that lwIP could fill this gap in the future, > > > > >> but no one is actively continuing this work as far as I am aware[1]. > > > > > > > > > > I have started integration on picotcp into barebox in 2015, see > > > > > https://lore.barebox.org/barebox/1436991230-14251-10-git-send-email-antonynpavlov@gmail.com/T/ > > > > > > Actually I made the first attempt to integrate picotcp into barebox in 2014, > > > see http://lists.infradead.org/pipermail/barebox/2014-May/019243.html > > > > > > 10 years is too long for this task :) > > > > > > In the message http://lists.infradead.org/pipermail/barebox/2015-July/024244.html > > > if I understand correctly Sascha asked me to keep network stuff > > > users (tftp, nfs, netconsole) as intact as possible. > > > > > > At the moment I understand that this task is too hard. > > > > > > The problem is: the network stuff users don't rely on "a network stack" > > > in the true sense. E.g. tftp_handler() takes an ETHERNET PACKET on > > > it's input, tftp_handler() skips Ethernet and IP stuff by itself > > > and modifies UDP fields directly! > > > > > > This week I have connected picotcp code to the existing network code > > > in the way that makes it possible to keep dhcp_handler() and > > > ftp_handler() intact. The result is ugly: barebox netdevice driver > > > receives frame from network, pass it to picotcp, picotcp parses > > > network protocol headers and extracts udp payload, next > > > picotcp passes udp payload back to my picotcp-to-barebox adapter, > > > the adapter RECONSTRUCTS ETHERNET PACKET and give it to tftp/dhcp_handler()! > > > This horrible approach creates more problems than it solves! > > > So if I understand correctly you tried passing *all* incoming packets to > > picotcp and route some of them back to the barebox network stack. > > for every barebox network device I create picotcp network device > which can send packets by picotcp initiative. > net_receive() just calls pico_stack_recv() with corresponding > picotcp network device as an argument, so no code change in drivers/net/. > net_poll() just calls pico_stack_tick(). > So all incoming packets go to picotcp only. > Picotcp can send packet if necessary without barebox interraction. > > UDP datagrams processed by picotcp routed to corresponding dhcp/tftp_handler(). > Are dhcp/tftp_handlers parts of barebox network stack? > > > Instead of passing all packets to picotcp, can't we just dispatch the > > incoming packets on a per-port basis in barebox and only pass the ones > > picotcp shall handle to picotcp? > > Good idea. I have to try. We can reroute IPv6 traffic to picotcp in net_receive() > and reroute TCP/IPv4 traffic to picotcp in net_handle_ip(). You could route all TCP to picotcp. Also everything that falls through net_handle_udp() can be routed to picotctp as well. > > > So basically a struct net_connection with the handler set to the picotcp > > receive function? > > net_connection handler is set to the normal unamended dhcp/tftp_handlers. > > > That way it might be possible to have the barebox network stack and > > picotcp in parallel and port the handlers over to pictotcp one by one. > > But I see a problem here. If there is a ARP respond in the incoming traffic > I have no idea there to send it. Both barebox network code and picotcp > can make ARP request. I suppose can just route ARP respond to the both stacks. Yes, sending it to both stacks should be fine. When a response is coming in and nobody wait for it then both barebox and picotctp should just discard it. > > But what I have to do if an ARP or ICMP echo __request__ is received? Should go to only one of both stacks, otherwise we would get duplicate ping responses. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |