From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/7] replace cdev_by_name() with cdev_open_by_name()
Date: Thu, 16 May 2024 17:01:12 +0200 [thread overview]
Message-ID: <ZkYfuL7ogbKcYgTP@pengutronix.de> (raw)
In-Reply-To: <20240516144304.gtzxiuhvvjuprxwj@pengutronix.de>
On Thu, May 16, 2024 at 04:43:04PM +0200, Marco Felsch wrote:
> Hi Sascha,
>
> On 24-05-16, Sascha Hauer wrote:
> > As Ahmad noticed cdev_by_name() doesn't increase the reference counting
> > on the returned cdev which causes problems further down the road. This
> > series replaces some of the easier occurences of cdev_by_name() with
> > cdev_open_by_name().
>
> Can we kindly inform the user with a print_once() or so that
> cdev_by_name should be replaced with cdev_open_by_name()?
Some of the call sites of cdev_by_name() are used frequently on all
boards, so this wouldn't be practical.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-05-16 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 7:08 Sascha Hauer
2024-05-16 7:08 ` [PATCH 1/7] ARM: Freescale i.MX23 evk: use cdev_open_by_name() Sascha Hauer
2024-05-16 7:08 ` [PATCH 2/7] ARM: tx28: " Sascha Hauer
2024-05-16 7:08 ` [PATCH 3/7] ARM: omap: " Sascha Hauer
2024-05-16 7:08 ` [PATCH 4/7] ARM: Rockchip: " Sascha Hauer
2024-05-16 7:08 ` [PATCH 5/7] commands: devlookup: " Sascha Hauer
2024-05-16 7:08 ` [PATCH 6/7] commands: findmnt: " Sascha Hauer
2024-05-16 7:08 ` [PATCH 7/7] bootm: " Sascha Hauer
2024-05-16 14:43 ` [PATCH 0/7] replace cdev_by_name() with cdev_open_by_name() Marco Felsch
2024-05-16 15:01 ` Sascha Hauer [this message]
2024-05-21 6:17 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkYfuL7ogbKcYgTP@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox