From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Jul 2024 10:10:03 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sYhvn-004Osg-0K for lore@lore.pengutronix.de; Tue, 30 Jul 2024 10:10:03 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYhvm-00042S-AD for lore@pengutronix.de; Tue, 30 Jul 2024 10:10:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QV4f74Tgs/5Zgc1AMLIGxfOsPYtatvAfTIyJkGrnvwY=; b=X59xB8+5h39SwukURAHG6EbFR2 6SQn7ElLC7gJ0h7hPZEsTUIRHFv0E+unTdNsPLLBWQYergl2Vu6Itgwz+y+y00hx88oyq4YZ1yK86 521+K3uUKJvwxvm44cthiK69LQQkBHx9nJYps4LdQtMJ7mPcFECbAPDgSJ6byAfJSaN+2lpMb4QCa lyW3H3snx3vgYrmmMLNrRFcH/14gBdYUAcOJDdt0rFOH3Cm+GsSe0I3F7egY3HrJ2Tqq7yXRH88oI ffXxAYUvmQJE20JQ6IrCaSZKrxAFusnwGpyohVfVrDTipw6UqKh9Luow241J5I9xZu7Q91/QPI1Cz LwBSQRrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhvJ-0000000EApw-0QhS; Tue, 30 Jul 2024 08:09:33 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhvG-0000000EApD-0XV9 for barebox@lists.infradead.org; Tue, 30 Jul 2024 08:09:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYhvD-0003ze-4m; Tue, 30 Jul 2024 10:09:27 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYhvC-003EmZ-OI; Tue, 30 Jul 2024 10:09:26 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sYhvC-0094MI-28; Tue, 30 Jul 2024 10:09:26 +0200 Date: Tue, 30 Jul 2024 10:09:26 +0200 From: Sascha Hauer To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: References: <20240726122623.3566935-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726122623.3566935-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_010930_190822_31027E62 X-CRM114-Status: GOOD ( 39.06 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [RESEND][PATCH 1/2] console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Fri, Jul 26, 2024 at 02:26:22PM +0200, Ahmad Fatoum wrote: > We already have three CONSOLE_ACTIVATE options and every one of them has > drawbacks: > > - ACTIVATE_ALL: May write barebox log to external devices like MCUs > that don't expect it > > - ACTIVATE_FIRST: Not applicable for most systems that probe from > device tree, where the order of probe is not necessarily fixed, > so what console is first may change over updates > > - ACTIVATE_NONE: has a misleading name and may leave the user without > any consoles at all if nothing else activates a console > > Let's add a new option and make it the default, which avoids all these > issues: Like ACTIVATE_NONE, it expects board code, DT or environment to > enable a console and if none of them do it falls back to activating all > consoles, so the user isn't kept in the dark with an error instructing > the user to fix this. > > Signed-off-by: Ahmad Fatoum > --- > Sent out second patch only by mistake instead of both... > --- > common/Kconfig | 19 ++++++++++++++++++- > common/console.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+), 1 deletion(-) > > diff --git a/common/Kconfig b/common/Kconfig > index 31360892aeef..2dda5ce5743a 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -812,7 +812,7 @@ endchoice > choice > prompt "Console activation strategy" > depends on CONSOLE_FULL > - default CONSOLE_ACTIVATE_FIRST > + default CONSOLE_ACTIVATE_ALL_FALLBACK > > config CONSOLE_ACTIVATE_FIRST > bool > @@ -831,6 +831,23 @@ config CONSOLE_ACTIVATE_ALL > Only the first registered console will have the full startup > log though. > > +config CONSOLE_ACTIVATE_ALL_FALLBACK > + bool > + prompt "activate all consoles as fallback" > + help > + This option is similar to CONFIG_CONSOLE_ACTIVATE_NONE in that it > + leaves consoles disabled on startup. If by the end of barebox > + startup, no consoles have been activated via board code, device > + tree or environment, barebox will enable all registered consoles > + as fallback, so the user has a chance to see output. > + > + This will be indicated by a fat error, so the user knows that > + the configuration needs to be fixed. If you don't see any > + output at all, consider trying again after enabling > + CONFIG_CONSOLE_ACTIVATE_ALL, so consoles are activated immediately > + at registration time and/or with CONFIG_DEBUG_LL, so barebox output > + is written even before console drivers were registered. > + > config CONSOLE_ACTIVATE_NONE > prompt "leave all consoles disabled" > bool > diff --git a/common/console.c b/common/console.c > index 73b4c4d4db01..e83a3e1e2d7f 100644 > --- a/common/console.c > +++ b/common/console.c > @@ -450,6 +450,33 @@ int console_unregister(struct console_device *cdev) > } > EXPORT_SYMBOL(console_unregister); > > +static int console_activate_all_fallback(void) > +{ > + int activate = CONSOLE_STDIOE; > + struct console_device *cdev; > + > + for_each_console(cdev) { > + if (cdev->f_active & (CONSOLE_STDOUT | CONSOLE_STDERR)) > + return 0; > + } > + > + if (IS_ENABLED(CONFIG_CONSOLE_DISABLE_INPUT)) > + activate &= ~CONSOLE_STDIN; > + > + for_each_console(cdev) > + console_set_active(cdev, activate); > + > + /* > + * This is last resort, so the user is not kept in the dark. > + * Writing to all consoles is a bad idea as the devices at the > + * other side might get confused by it, thus the error log level. > + */ > + pr_err("No consoles were activated. Activating all consoles as fallback!\n"); > + > + return 0; > +} > +postenvironment_initcall(console_activate_all_fallback); Shouldn't this code only run when CONSOLE_ACTIVATE_ALL_FALLBACK is enabled? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |