Re: [PATCH v2 00/19] Add ECDSA support for FIT image verification

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Aug 06, 2024 at 08:03:48AM +0200, Sascha Hauer wrote:
> 
> On Thu, 01 Aug 2024 07:57:18 +0200, Sascha Hauer wrote:
> > This series implements ECDSA signature verification for FIT images.
> > The ECDSA code itself is taken from the Kernel. Currently only supported
> > way to specify a ECDSA key is to compile it into the binary using
> > CONFIG_CRYPTO_ECDSA_KEY, taking it from a device tree is not ye
> > supported.
> > 
> > Changes since v1:
> > - better split up rsatoc patches
> > - keep engine support around in rsatoc as it is still needed in many
> >   cases
> > - Add more cleanup to rsatoc
> > 
> > [...]
> 
> Applied, thanks!
> 
> [01/19] errno: include string for EOPNOTSUPP
>         https://git.pengutronix.de/cgit/barebox/commit/?id=1ad1a884407f (link may not be stable)
> [02/19] rsatoc: disable deprecated function warnings
>         https://git.pengutronix.de/cgit/barebox/commit/?id=d64d733d2451 (link may not be stable)
> [03/19] rsatoc: remove unnecessary function call
>         https://git.pengutronix.de/cgit/barebox/commit/?id=42731deb592f (link may not be stable)
> [04/19] rsatoc: pass EVP_PKEY around
>         https://git.pengutronix.de/cgit/barebox/commit/?id=b1fef1396772 (link may not be stable)
> [05/19] rsatoc: rename rsa_err() to openssl_error()
>         https://git.pengutronix.de/cgit/barebox/commit/?id=5206d3b61418 (link may not be stable)
> [06/19] rsatoc: move engine initialization to engine_get_pub_key()
>         https://git.pengutronix.de/cgit/barebox/commit/?id=89d32ef83ecd (link may not be stable)
> [07/19] rsatoc: cleanup error handling
>         https://git.pengutronix.de/cgit/barebox/commit/?id=c99779284ce5 (link may not be stable)
> [08/19] rsatoc: remove unnecessary error check
>         https://git.pengutronix.de/cgit/barebox/commit/?id=2ec045398f6d (link may not be stable)
> [09/19] rsatoc: use non deprecated openssl functions to retrieve RSA params
>         https://git.pengutronix.de/cgit/barebox/commit/?id=cc0b8a2e7606 (link may not be stable)
> [10/19] rsatoc: check error value of gen_key()
>         https://git.pengutronix.de/cgit/barebox/commit/?id=6df30149362d (link may not be stable)
> [11/19] rsatoc: rename to keytoc
>         https://git.pengutronix.de/cgit/barebox/commit/?id=7b51f76a4534 (link may not be stable)
> [12/19] keytoc: add ecdsa support
>         https://git.pengutronix.de/cgit/barebox/commit/?id=994f3df141f5 (link may not be stable)
> [13/19] keytoc: Let openssl_error() take a format string
>         https://git.pengutronix.de/cgit/barebox/commit/?id=73a0f34fddc7 (link may not be stable)
> [14/19] keytoc: clarify error messages
>         https://git.pengutronix.de/cgit/barebox/commit/?id=cfd2a8f1fc19 (link may not be stable)

Really I applied up to this patch with Ahmads comments applied. The
remaining ones need some more work which I'll do later.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |