mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] acpi: fix compilation for 32-bit
Date: Tue, 20 Aug 2024 14:13:36 +0200	[thread overview]
Message-ID: <ZsSIcEPr4AlQuwxL@pengutronix.de> (raw)
In-Reply-To: <20240815114455.2723000-1-a.fatoum@pengutronix.de>

On Thu, Aug 15, 2024 at 01:44:55PM +0200, Ahmad Fatoum wrote:
> From: Ahmad Fatoum <ahmad@a3f.at>
> 
> Build test on x86 fails due to pointer cast and because of forcing the
> bigger alignment on the flexible array.
> 
> The problematic pointer cast is for the XSDT, which is 64-bit-only, so
> let's fix the cast and return an error if we somehow see an XSDT on
> 32-bit.
> 
> For the flexible array, let's use the size of the pointer for the
> alignment.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> v1 -> v2: 
>   - fix CI x86_64 breakage, by keeping the packed/aligned specifiction
>     as is, but changing it to 32-bit on 32-bit systems.
> ---
>  drivers/bus/acpi.c | 6 ++++--
>  include/acpi.h     | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)

I seem to have applied v1 of this patch. Can you send a fixup?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  parent reply	other threads:[~2024-08-20 12:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 11:44 Ahmad Fatoum
2024-08-20 12:07 ` Sascha Hauer
2024-08-20 12:13 ` Sascha Hauer [this message]
2024-08-22 10:52 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsSIcEPr4AlQuwxL@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox