Re: [PATCH 5/7] mfd: rk808: add support for RK806

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Oct 16, 2024 at 10:07:57AM +0300, Alexander Shiyan wrote:
> Oh, I see that in [4/7]. Sorry for the noise.

I think you are misreading the patch. Indeed the RK806 can work in I2C
mode and my patch series currently doesn't support this. I have two
different of_device_id tables, one used for I2C and the other for SPI.
RK806 currently only is in the SPI table, not in the I2C table.

I2C support for RK806 is likely only a matter of adding the compatible
entry. I can add it, but I cannot test it. Do you have a hardware to
test this on?

Sascha


> 
> вт, 15 окт. 2024 г. в 17:46, Alexander Shiyan <eagle.alexander923@gmail.com>:
> >
> > вт, 15 окт. 2024 г. в 14:21, Sascha Hauer <s.hauer@pengutronix.de>:
> > >
> > > This adds support for the RK806 to the rk808 driver. Additionally to
> > > I2C this variant comes with SPI support, so add SPI probe support to the
> > > driver.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Hello Sascha.
> >
> > RK806 can also work via I2C. Can you add this compatibility together?
> >
> > Thanks!
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |