mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: add custom autoboot_abort_key
Date: Tue, 22 Oct 2024 11:53:25 +0200	[thread overview]
Message-ID: <Zxd2FV4C6wca_dOJ@pengutronix.de> (raw)
In-Reply-To: <20240916135300.3996776-1-johannes.schneider@leica-geosystems.com>

Hi Johannes,

On Mon, Sep 16, 2024 at 03:53:00PM +0200, Johannes Schneider wrote:
> Add the Kconfig options to select a compile-time custom key(s) that
> can be used to enter the console when barebox prompts for:
> "Hit <custom_key> to stop autoboot."

Having a custom key to stop autoboot is generally fine. Defining the key
at compile time not so.

Instead we could convert autoboot_abort_key from
globalvar_add_simple_enum() to dev_add_param_string(&global_device,...)
the set function could then accept "any", "ctrl-c" or any other single
digit string.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2024-10-22 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 13:53 Johannes Schneider
2024-10-22  9:53 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxd2FV4C6wca_dOJ@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=johannes.schneider@leica-geosystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox