From: "Tomaž Šolc" <tomaz.solc@klevio.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] mci: move after pinctrl in link order.
Date: Mon, 18 Feb 2019 10:54:43 +0100 [thread overview]
Message-ID: <a0535f65-c8e3-4e01-9be7-fb9b1a896ee5@klevio.com> (raw)
In-Reply-To: <20190218084244.j5eoggrgfgedsuuo@pengutronix.de>
On 18. 02. 19 09:42, Sascha Hauer wrote:
> On Thu, Feb 14, 2019 at 02:24:27PM +0100, Tomaz Solc wrote:
>> pinctrl driver needs to be initialized before mci driver or the pinctrl
>> device tree properties in the mci node are ignored. Since mci is already
>> initialized by the coredevice_initcall(), changing the link order is currently
>> the only way to ensure that.
>
> The same applies most other subsystems, so instead of moving mci down I
> would rather suggest to move pinctrl up.
>
> The other thing is: Why does the bcm2835 mci driver use coredevice_initcall()
> at all? Normally it should be a device_initcall(). Since the
> coredevice_initcall() goes back to the initial commit of the driver I
> suspect there is no special reason for that decision and so I think we
> should just change to device_initcall().
Good point. I checked other drivers under mci/ and it seems they all use
device_initcall(). I thought that storage must come before
fs_initcall(), but that is not actually the case. As far as I can see,
nothing breaks by moving mci-bcm2835 to device_initcall(). I'll update
the patch.
Best regards
Tomaž
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-18 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:24 [PATCH 0/7] Fixing MMC access on Raspberry Pi CM3 Tomaz Solc
2019-02-14 13:24 ` [PATCH 1/7] ARM: rpi: switch emmc from sdhost to sdhci Tomaz Solc
2019-02-14 13:24 ` [PATCH 2/7] Kconfig: add pin controllers submenu Tomaz Solc
2019-02-14 13:24 ` [PATCH 3/7] pinctrl: bcm2835: move existing code from gpio Tomaz Solc
2019-02-14 13:24 ` [PATCH 4/7] pinctrl: bcm2835: register the pin controller Tomaz Solc
2019-02-14 13:24 ` [PATCH 5/7] mci: move after pinctrl in link order Tomaz Solc
2019-02-14 23:34 ` Andrey Smirnov
2019-02-18 8:42 ` Sascha Hauer
2019-02-18 9:54 ` Tomaž Šolc [this message]
2019-02-14 13:24 ` [PATCH 6/7] mci: bcm2835: parse other device tree properties Tomaz Solc
2019-02-14 13:24 ` [PATCH 7/7] ARM: rpi: Add device tree for Compute Module 3 Tomaz Solc
2019-02-14 14:15 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0535f65-c8e3-4e01-9be7-fb9b1a896ee5@klevio.com \
--to=tomaz.solc@klevio.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox