Hi Sascha, Am 2019-01-28 09:02, schrieb Sascha Hauer: >> static int rpi_board_rev = 0; >> @@ -211,10 +225,12 @@ static void rpi_get_board_rev(void) >> * >> http://www.raspberrypi.org/forums/viewtopic.php?f=31&t=20594 >> */ >> rpi_board_rev = msg->get_board_rev.body.resp.rev; >> + printf("RPI: Board rev %x\n", rpi_board_rev); >> if (rpi_board_rev & 0x800000) { >> rpi_board_rev = (rpi_board_rev >> 4) & 0xff; >> rpi_models = rpi_models_new_scheme; >> rpi_models_size = ARRAY_SIZE(rpi_models_new_scheme); >> + printf("RPI: Board rev %u new\n", rpi_board_rev); > > Are these printfs necessary? Looks like debugging aid. If yes, please > remove. You're right, they were overseen and are a debugging leftover. > Otherwise the patch looks fine, but I can't apply it due to whitespace > damages. Could you send it using git-send-emain? If that's no option > maybe a github pull request could do it. This time as attachement, hope it works better. Best regards Moritz